Cardano.Wallet.Shelley.Launch.BlockfrostSpec

lib/shelley/cardano-wallet.cabal

@@ -220,6 +220,8 @@ test-suite unit
     , bech32
     , bech32-th
     , bytestring
+    , blockfrost-api
+    , blockfrost-client
     , cardano-addresses
     , cardano-api
     , cardano-crypto
@@ -273,6 +275,7 @@ test-suite unit
       Cardano.Wallet.Shelley.CompatibilitySpec
       Cardano.Wallet.Shelley.Compatibility.LedgerSpec
       Cardano.Wallet.Shelley.LaunchSpec
+      Cardano.Wallet.Shelley.Launch.BlockfrostSpec
       Cardano.Wallet.Shelley.NetworkSpec
       Cardano.Wallet.Shelley.TransactionSpec
       Spec

lib/shelley/exe/cardano-wallet.hs

@@ -63,8 +63,6 @@ import Cardano.CLI
     , tokenMetadataSourceOption
     , withLogging
     )
-import Cardano.Launcher.Node
-    ( CardanoNodeConn )
 import Cardano.Startup
     ( ShutdownHandlerLog
     , installSignalHandlers
@@ -102,9 +100,8 @@ import Cardano.Wallet.Shelley.BlockchainSource
 import Cardano.Wallet.Shelley.Launch
     ( Mode (Light, Normal)
     , NetworkConfiguration (..)
-    , modeFlag
+    , modeOption
     , networkConfigurationOption
-    , nodeSocketOption
     , parseGenesisData
     )
 import Cardano.Wallet.Version
@@ -185,7 +182,6 @@ data ServeArgs = ServeArgs
     , _mode :: Mode
     , _listen :: Listen
     , _tlsConfig :: Maybe TlsConfiguration
-    , _nodeSocket :: CardanoNodeConn
     , _networkConfiguration :: NetworkConfiguration
     , _database :: Maybe FilePath
     , _syncTolerance :: SyncTolerance
@@ -203,10 +199,9 @@ cmdServe = command "serve" $ info (helper <*> helper' <*> cmd) $
 
     cmd = fmap exec $ ServeArgs
         <$> hostPreferenceOption
-        <*> modeFlag
+        <*> modeOption
         <*> listenOption
         <*> optional tlsOption
-        <*> nodeSocketOption
         <*> networkConfigurationOption
         <*> optional databaseOption
         <*> syncToleranceOption
@@ -221,7 +216,6 @@ cmdServe = command "serve" $ info (helper <*> helper' <*> cmd) $
       mode
       listen
       tlsConfig
-      conn
       networkConfig
       databaseDir
       sTolerance
@@ -242,12 +236,10 @@ cmdServe = command "serve" $ info (helper <*> helper' <*> cmd) $
                 setupDirectory (logInfo tr . MsgSetupDatabases)
 
             blockchainSource <- case mode of
-                Normal ->
+                Normal conn ->
                     pure $ NodeSource conn vData
-                Light (Just token) ->
+                Light token ->
                     BlockfrostSource <$> Blockfrost.readToken token
-                Light Nothing ->
-                    exitWith $ ExitFailure 34
 
             exitWith =<< serveWallet
                 blockchainSource

lib/shelley/src/Cardano/Wallet/Shelley/Launch.hs

@@ -35,7 +35,7 @@ module Cardano.Wallet.Shelley.Launch
 
     -- * Light Mode
     , Mode (..)
-    , modeFlag
+    , modeOption
     ) where
 
 import Prelude
@@ -79,17 +79,7 @@ import Data.Text.Class
 import GHC.TypeLits
     ( KnownNat, Nat, SomeNat (..), someNatVal )
 import Options.Applicative
-    ( Parser
-    , eitherReader
-    , flag
-    , flag'
-    , help
-    , long
-    , metavar
-    , option
-    , optional
-    , (<|>)
-    )
+    ( Parser, eitherReader, flag', help, long, metavar, option, (<|>) )
 import Ouroboros.Network.Magic
     ( NetworkMagic (..) )
 import Ouroboros.Network.NodeToClient
@@ -400,12 +390,15 @@ instance HasSeverityAnnotation TempDirLog where
                                     Mode
 -------------------------------------------------------------------------------}
 
-data Mode = Normal | Light (Maybe Blockfrost.TokenFile)
+data Mode = Normal CardanoNodeConn | Light Blockfrost.TokenFile
   deriving (Show)
 
-modeFlag :: Parser Mode
-modeFlag = do
-    light <- flag False True $
-        mconcat [ long "light", help "Enable light mode" ]
-    creds <- optional Blockfrost.tokenFileOption
-    pure $ if light then Light creds else Normal
+modeOption :: Parser Mode
+modeOption = normalMode <|> lightMode
+  where
+    normalMode =
+        Normal <$> nodeSocketOption
+    lightMode =
+        flag' () (long "light" <> help "Enable light mode") *>
+        fmap Light Blockfrost.tokenFileOption
+

lib/shelley/src/Cardano/Wallet/Shelley/Launch/Blockfrost.hs

@@ -14,14 +14,14 @@ import Blockfrost.Client.Core
 import Blockfrost.Client.Types
     ( Project (..) )
 import Options.Applicative
-    ( Parser, auto, help, long, metavar, option )
+    ( Parser, help, long, metavar, option, str )
 
 newtype TokenFile = TokenFile FilePath
-    deriving newtype (Eq, Show, Read)
+    deriving newtype (Eq, Show)
 
 -- | --blockfrost-token-file FILE
 tokenFileOption :: Parser TokenFile
-tokenFileOption = option auto $ mconcat
+tokenFileOption = option (TokenFile <$> str) $ mconcat
     [ long "blockfrost-token-file"
     , metavar "FILE"
     , help $ mconcat

lib/shelley/test/unit/Cardano/Wallet/Shelley/Launch/BlockfrostSpec.hs

@@ -0,0 +1,65 @@
+module Cardano.Wallet.Shelley.Launch.BlockfrostSpec
+    ( spec
+    ) where
+
+import Prelude
+
+import qualified Blockfrost.Client.Types as Blockfrost
+import qualified Data.Text as T
+
+import Blockfrost.Env
+    ( Env (Testnet) )
+import Cardano.Wallet.Shelley.Launch
+    ( Mode (Light, Normal), modeOption )
+import Cardano.Wallet.Shelley.Launch.Blockfrost
+    ( readToken )
+import Options.Applicative
+    ( ParserFailure (execFailure)
+    , ParserResult (CompletionInvoked, Failure, Success)
+    , defaultPrefs
+    , execParserPure
+    , fullDesc
+    , info
+    )
+import Test.Hspec
+    ( Spec, describe, expectationFailure, it, shouldBe, shouldReturn )
+import UnliftIO
+    ( withSystemTempFile )
+import UnliftIO.IO
+    ( hClose )
+
+spec :: Spec
+spec = describe "Blockfrost CLI options" $ do
+    it "modeOption --node-socket" $ do
+        let parserInfo = info modeOption fullDesc
+            args = ["--node-socket", "/tmp/file"]
+        case execParserPure defaultPrefs parserInfo args of
+            Failure pf -> expectationFailure $ show pf
+            CompletionInvoked cr -> expectationFailure $ show cr
+            Success (Light _) -> expectationFailure "Normal mode expected"
+            Success (Normal _conn) -> pure ()
+
+    it "modeOption --light" $ withSystemTempFile "blockfrost.token" $ \f h -> do
+        let parserInfo = info modeOption fullDesc
+            args = ["--light", "--blockfrost-token-file", f]
+            net = "testnet"
+            projectId = "jlUej4vcMt3nKPRAiNpLUEeKBIEPqgH2"
+        case execParserPure defaultPrefs parserInfo args of
+            Failure pf -> expectationFailure $ show pf
+            CompletionInvoked cr -> expectationFailure $ show cr
+            Success (Normal _conn) -> expectationFailure "Light mode expected"
+            Success (Light tf) -> do
+                hClose h *> writeFile f (net <> projectId)
+                readToken tf `shouldReturn`
+                    Blockfrost.Project Testnet (T.pack projectId)
+
+    it "modeOption requires --light flag" $ do
+        let parserInfo = info modeOption fullDesc
+            args = ["--blockfrost-token-file", "/tmp/file"]
+        case execParserPure defaultPrefs parserInfo args of
+            Failure pf | (help, _code, _int) <- execFailure pf "" ->
+                show help `shouldBe`
+                    "Missing: --light\n\n\
+                    \Usage:  (--node-socket FILE | \
+                    \--light --blockfrost-token-file FILE)"
+            result -> expectationFailure $ show result