Simple Example - Centralized Telescope with BLS #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrtoledo
previously approved these changes
Jan 14, 2025
…o-scaling/alba into curiecrypt/simple-example
rrtoledo
reviewed
Jan 21, 2025
rrtoledo
previously approved these changes
Jan 21, 2025
Co-authored-by: Tolik Zinovyev <aszinovyev@gmail.com>
| // Create the telescope structure | ||
| let alba = Telescope::create(soundness_param, completeness_param, set_size, lower_bound); | ||
|
|
||
| let mut public_key_list: Vec<(usize, PublicKey)> = Vec::with_capacity(nb_elements as usize); |
There was a problem hiding this comment.
The usize variable always contains its own index, so it is redundant and can be removed.
| if let Some(signature_entry) = signatures.iter().find(|entry| entry.signature == *sig) { | ||
| if public_key_list | ||
| .iter() | ||
| .any(|entry| entry.0 == signature_entry.index) |
There was a problem hiding this comment.
I think this logic wouldn't work if you pass signatures to this function that are not index 0, 1, ..., n_p-1. That's why in my document Aggregate gets triples (i, s_i, w_i). In particular, the index i of the signature is included.
Also, public_key_list seems redundant in this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a basic example of integrating a multi-signature scheme into the Centralized Telescope.
It consists of the functionality
KeyGen,Sign,Aggregate, andVerifyproposed in the Definition 3. of Alba Definitions by @tolikzinovyev.Pre-submit checklist
Issue(s)
Relates to #114