menu cleanup #1: tagging in tags column, metas in name column

[npinsker]

move 'tag' button to tags column, which is more intuitive.

i didn't bother to add hover behavior to the tag button because i'm planning to remove these icons altogether, but am splitting the commit up a bit.

almost all of this is just c/p between different files, the work was basically already done for me

move meta-parenting stuff to the puzzle edit modal and remove it from the tag modal

[npinsker]

i just c/p this from another file but i wonder if it can be simplified -- what are hunt tags vs. puzzle tags?

[akirabaruah]

I think they're actually the same type of object, but hunt implies "all" while puzzle implies individual tags.

More detail: The backend defines PuzzleTags and uses that nomenclature. Each of these PuzzleTags is associated with a single Hunt. The frontend also uses the PuzzleTag nomenclature, but also calls them huntTags like this:

cardboard/hunts/src/huntSlice.tsx

Line 46 in 2a84a9b

export const selectHuntTags = createSelector(

We can probably just call them tags in the frontend instead of puzzleTag and allTags instead of huntTags since we don't have any other notion of tags in Cardboard AFAIK.

[npinsker]

is there any difference between the “hunts tags” derived that way and the “puzzle tags” from

cardboard/hunts/src/puzzlesSlice.tsx

Line 386 in 2a84a9b

export const selectPuzzleTags = createSelector(

? (in the edit tags modal, those two sets are merged — do they need to be?)

[rgossiaux]

Yeah so this huntTags thing is the set of all the tags in the hunt at the time when we loaded the hunt object (which is only once at page load). The puzzleTags is the set of all the tags that are currently in use on a puzzle. These two sets are a bit distinct--huntTags will contain all the default tags even if they aren't in use, while puzzleTags will contain any tags that were created after the page was loaded (including meta tags).

I think combining to only a single source would mean adding some more polling just for tags which I might be a little apprehensive about although it's conceptually a lot cleaner.

I think this code isn't going to work as a result, I think you want puzzleTags and not huntTags. I suspect that if a meta is created after the page is loaded its tag won't appear here.

[akirabaruah]

i didn't bother to add hover behavior to the tag button because i'm planning to remove these icons altogether, but am splitting the commit up a bit.

Yeah, with the new arrangement, changing the tag icon to a plus or something would probably make more sense visually, but if we're getting rid of the icon entirely (#851 ?), then LGTM.

[rgossiaux]

Yeah so this huntTags thing is the set of all the tags in the hunt at the time when we loaded the hunt object (which is only once at page load). The puzzleTags is the set of all the tags that are currently in use on a puzzle. These two sets are a bit distinct--huntTags will contain all the default tags even if they aren't in use, while puzzleTags will contain any tags that were created after the page was loaded (including meta tags).

I think combining to only a single source would mean adding some more polling just for tags which I might be a little apprehensive about although it's conceptually a lot cleaner.

I think this code isn't going to work as a result, I think you want puzzleTags and not huntTags. I suspect that if a meta is created after the page is loaded its tag won't appear here.

[npinsker]

I verified that your bug happened, changed code to use puzzleTags, and verified it no longer happens

[rgossiaux]

Great ty. Prolly a good indicator that the underlying code could use some improvements (naming and/or commenting at the least).