Feature request: Disable quick-install for specific crate in Cargo.toml

[NobodyXu]

Our project just had a mis-adventure with binstall. It seems that cargo binstall preferred to download binaries from QuickInstall as opposed to our own, and they turned out to be broken.

martinvonz/jj#3844 (comment)
cargo-bins/cargo-quickinstall#250

Is there a way to specify in our Cargo.toml that our binaries should be preferred? We already have some cargo binstall config:
https://github.com/martinvonz/jj/blob/65a988e3d2d6b3ed201ed8c2b4952ef08344e55f/cli/Cargo.toml#L118-L121

Another issue is that we only provide musl binaries, so perhaps binstall prefers QuickInstall because it has gnu binaries.

Originally posted by @ilyagr in #19 (comment)

[ilyagr]

I think this would be great! Thank you for considering it.

Clearly, QuickInstall is wonderful to have and make available to users, especially for projects that aren't aware of cargo binstall, but also for unusual targets. The only problem is that we'd like to make the installation of binaries from sources other than https://github.com/martinvonz/jj/releases to be opt-in, so that users know they installed unofficial binaries when they file a bug report. A setting in Cargo.toml would be perfect.

One possibility I was thinking of is that, if the install of official binaries fails, binstall could tell the user "You can try cargo binstall --allow-unofficial-binaries --allow-install-from-source jj-cli to install from other sources" (instead of installing from source). But a simple disabling of quickinstall would also work.

[NobodyXu]

That can be added after Cargo.toml configuration support is done

[ilyagr]

I'm not sure when/if I would get to it, but would you accept a PR for this or do you prefer to do these kinds of features yourself (because it's easier or for any other reason)?

[NobodyXu]

Yes, I welcome any PR and contribution from cummunity!
FYI binstalk-{type, manifest} contain the manifest
And the binstalk is where you need to put the per-crate quick-install disable logic in

[senekor]

I have another idea, created a PR directly because the diff is tiny. Just close it if that's no good. We can just change the order of preference such that official binaries are always preferred over quickinstall ones.

#1741

[ilyagr]

Just to say this explicitly: while #1741 is very helpful, and decreases the urgency as far as jj is concerned, I believe this feature still desirable in some form. I think you think so too as you haven't closed this.

If a project distributes official binaries via binstall, and even if the user is on a platform there are no official binaries for,
they should on one hand be able to get them from QuickInstall, but on the other hand there has to be a way to make sure binstall warns them that they are getting unofficial binaries. So, I think binstall should fail by default in this case, but tell the user how to override it and allow QuickInstall installation.

[NobodyXu]

Yeah I agree, probably time to focus on cargo-binstall in my free time

[ilyagr]

At this point, I don't think this is urgent, but it would be nice. Thank you for maintaining `binstall`, it is so very useful.