-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolve): prefer official binaries #1741
Conversation
Nice! I can't judge whether this is acceptable for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code, thank you!
I thought about this and thought it is harder than expected, but turns out just changing order will work!
@ilyagr Can you update the e2e-tests/live.sh to include jj for this? |
@NobodyXu I guess you meant me? 🙂 I added the test 👍 |
Some CI failures:
I got similar errors locally, but was able to fix them by exporting a GitHub personal access token, so I assumed it's a rate limiting thing 🤔 |
3806dfa
to
23385d4
Compare
23385d4
to
2b57b6a
Compare
Turns out it's because github forbids actions from accessing secrets, since you are not a collaborator. |
This is an alternative idea to solve #1721.
It makes much more sense to me to prefer official binaries (i.e. ones resolved from an "earlier strategy") with a secondary target (e.g.
musl
instead ofgnu
on linux) over binaries from a later strategy (quickinstall).I have only quickly rummaged through the source code and confirmed it works with installing
jj-cli
from the official release page instead of quickinstall, I don't know if this impacts something else.