fix(resolve): prefer official binaries

[senekor]

This is an alternative idea to solve #1721.

It makes much more sense to me to prefer official binaries (i.e. ones resolved from an "earlier strategy") with a secondary target (e.g. musl instead of gnu on linux) over binaries from a later strategy (quickinstall).

I have only quickly rummaged through the source code and confirmed it works with installing jj-cli from the official release page instead of quickinstall, I don't know if this impacts something else.

[ilyagr]

Nice! I can't judge whether this is acceptable for binstall, but it certainly would elegantly solve our immediate problem.

[NobodyXu]

Nice code, thank you!

I thought about this and thought it is harder than expected, but turns out just changing order will work!

[NobodyXu]

@ilyagr Can you update the e2e-tests/live.sh to include jj for this?

[senekor]

@NobodyXu I guess you meant me? 🙂 I added the test 👍

[senekor]

Some CI failures:

Received status code 401 Unauthorized, will wait for 120s and retry

I got similar errors locally, but was able to fix them by exporting a GitHub personal access token, so I assumed it's a rate limiting thing 🤔

[NobodyXu]

Some CI failures:

Received status code 401 Unauthorized, will wait for 120s and retry

I got similar errors locally, but was able to fix them by exporting a GitHub personal access token, so I assumed it's a rate limiting thing 🤔

Turns out it's because github forbids actions from accessing secrets, since you are not a collaborator.