updated congo subregions #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git complains if this file does not end with a newline.
The way to disable a region is to set the `_enabled` field to `false`, not the `_disabled` field (which does not exist) to `true`. Since we are overwriting the subregions' types we don't need to disable them, just update their `type` field.
|
Hi @baldarn, I had to push some changes to your branch in order to make this work. In order to disable a subregion the Thank you for the contribution! |
|
Hi @baldarn, I unfortunately had to revert these changes. I didn't notice at first but this PR was applied to the wrong country. The iso code "CG" refers to The Republic of Congo which isn't the same country as The Democratic Republic of Congo (which has iso code "CD"). The "CD" files should have been modified, not "CG". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.