inline figures should not be converted to figures

[zkamvar]

EDIT: this is actually an issue with the fact that inline figures should not be converted to figures, but rather, they should remain images.

There is an issue whereby someone may want to add a link to an image or badge so that if someone clicks on an image, they are transported to another website.

This is an established practice as documented in the MDN docs

from carpentries/lesson-transition#65 (comment), @ostephens writes:

In Setup the link to Binder using the "My Binder" image with markup

[![Binder](https://mybinder.org/badge.svg)](https://mybinder.org/v2/gh/betatim/openrefineder/6ba108b?urlpath=%2Fopenrefine)

results in image being rendered by not linked. The HTML generated from the markup is

<figure href="https://mybinder.org/v2/gh/betatim/openrefineder/6ba108b?urlpath=%2Fopenrefine">
   <img src="https://mybinder.org/badge.svg" alt="Binder" class="figure mx-auto d-block">
</figure>

This is a problem in the fix_figures() function where we assume that the parent element of the image is a paragraph. This needs to change the code on line 58 to explicitly search for the first ancestor that is a paragraph element for this image (though this may fail for inline images)

sandpaper/R/utils-xml.R

Lines 54 to 68 in 3d088c7

	fix_figures <- function(nodes = NULL) {
	if (length(nodes) == 0) return(nodes)
	figs <- xml2::xml_find_all(nodes, ".//img")
	caps <- xml2::xml_find_all(nodes, ".//p[@class='caption']")
	fig_element <- xml2::xml_parent(figs)
	classes <- xml2::xml_attr(figs, "class")
	classes <- ifelse(is.na(classes), "", classes)
	classes <- paste(classes, "figure mx-auto d-block")
	xml2::xml_set_attr(figs, "class", trimws(classes))
	xml2::xml_set_name(caps, "figcaption")
	xml2::xml_set_attr(caps, "class", NULL)
	xml2::xml_set_name(fig_element, "figure")
	xml2::xml_set_attr(fig_element, "class", NULL)
	invisible(nodes)
	}

[zkamvar]

The solution was surprisingly straightforward:

in: 1b6af38:

-figs <- xml2::xml_find_all(nodes, ".//img")
+figs <- xml2::xml_find_all(nodes, ".//div[@class='figure']/img")