Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only process standalone images into figures #446

Merged
merged 9 commits into from
May 19, 2023
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Apr 28, 2023

This will fix #445 by only processing known figures.

That being said, it will be good to process the <img> tags that maintainers have added in because they wanted to control the width attributes.

TODO:

  • make sure to add "figure" class to images so they have a max width of 100%
  • process lonely image tags
  • investigate failures of this on nightly pandoc (likely because the figure class is now "float"?)
    <div class="float" id="fig-first">
      <img src="fig/Setup.png" class="imgclass" alt="alt text" />
      <div class="figcaption">link should be transformed</div>
    </div>

@zkamvar zkamvar marked this pull request as draft April 28, 2023 17:45
@zkamvar zkamvar marked this pull request as ready for review May 19, 2023 18:22
@zkamvar zkamvar merged commit 4b9d0c5 into main May 19, 2023
@zkamvar zkamvar deleted the fix-image-processing-445 branch May 19, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inline figures should not be converted to figures
1 participant