Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last accessibility marker can be omitted from legend in some cases #189

Closed
NickEntin opened this issue Jan 19, 2024 · 0 comments · Fixed by #188
Closed

Last accessibility marker can be omitted from legend in some cases #189

NickEntin opened this issue Jan 19, 2024 · 0 comments · Fixed by #188
Assignees
@NickEntin
Labels
bug Something isn't working as expected P1: High Priority Issues that would result in incorrectly accessing whether or not a view is accessible.

Comments

@NickEntin
Copy link
Collaborator

Due to a bug in the legend layout logic, the last item in a column may accidentally be put into the start of the next column. When it's the overall last item in the legend, this can cause it to be omitted from the snapshotted region entirely.
@NickEntin NickEntin added bug Something isn't working as expected P1: High Priority Issues that would result in incorrectly accessing whether or not a view is accessible. labels Jan 19, 2024
@NickEntin NickEntin self-assigned this Jan 19, 2024
@NickEntin NickEntin mentioned this issue Jan 19, 2024
Merged
@NickEntin NickEntin linked a pull request Jan 19, 2024 that will close this issue
Show legend in hit target snapshots #188
Merged
NickEntin added a commit that referenced this issue Jan 19, 2024
@NickEntin
Fix bug in legend layout causing items to fallover into next column
a4ac2c4 
Resolves #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickEntin NickEntin

Labels
bug Something isn't working as expected P1: High Priority Issues that would result in incorrectly accessing whether or not a view is accessible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show legend in hit target snapshots cashapp/AccessibilitySnapshot
1 participant
@NickEntin