Show legend in hit target snapshots #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
commented
Jan 18, 2024
| NSString *errorDescription = snapshotVerifyWithInvertedColors(self, selector, view__, identifier__ ?: @"", useMonochromeSnapshot__, maxPermissibleMissedRegionWidth__, maxPermissibleMissedRegionHeight__, 0, 0);\ | ||
| NSString *errorDescription = snapshotVerifyWithHitTargets(self, selector, view__, identifier__ ?: @"", useMonochromeSnapshot__, maxPermissibleMissedRegionWidth__, maxPermissibleMissedRegionHeight__, 0, 0);\ |
NickEntin
commented
Jan 18, 2024
| let maxYBoundary = bounds.minY + availableLegendHeight | ||
| let maxYBoundary = bounds.minY + Metrics.legendInsets.top + availableLegendHeight |
There was a problem hiding this comment.
This was an existing bug in the layout code for all accessibility snapshots, which could cause legend views to wrap to the next column too early.
There was a problem hiding this comment.
Retroactively filed #189 for this.
NickEntin
force-pushed
the
entin/hit-test-legend-2
branch
from
728af01 to
b9e2f25
Compare
NickEntin
commented
Jan 19, 2024
There was a problem hiding this comment.
Turns out #189 was actually affecting a fair number of snapshots 😓. This is an example where we were actually missing the last element since it fell over into the next (off screen) column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.