-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add js browser target to paging extensions #3843
Conversation
Okay, why limit it to iOS and jvm (and now js) only? What about all other targets, eg darwin or native? |
It's limited by what Multiplatform Paging supports. Currently it just supports iOS, JVM, and the (undocumented) JS targets. There's not a strong technical reason for not allowing |
@sproctor Thanks for doing this! If you need help with the CI errors, please lmk |
I tried my best on the CI errors, but I think they're now a bit past my expertise. Locally, I'm getting an internal compiler error when trying to run the tests and I'm also a bit confounded by the message generated here. |
… missing JS modules workaround
This won't work, you have to return @Test fun foo() = runTest { } And I mean this pattern: private fun testing(action: suspend () -> Unit): TestResult { // or put the driver in the action
return runTest {
before()
action()
after() // if needed
}
@Test fun foo() = testing {
} |
For testing you will also need to add some karma config files to copy the wasm file to a location that can be found by the test runner. e.g. from |
...oidx-paging3/src/commonTest/kotlin/app/cash/sqldelight/paging3/KeyedQueryPagingSourceTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.