Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove js tests from androidx-paging3 #4667

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Remove js tests from androidx-paging3 #4667

merged 2 commits into from
Sep 27, 2023

Conversation

dellisd
Copy link
Collaborator

@dellisd dellisd commented Sep 27, 2023

The sqljs driver is going bye bye and the paging extension currently does not support async drivers (i.e. the web-worker-driver).

It's unlikely that we'll ever have a new synchronous Kotlin/JS driver, but maybe if a synchronous Wasm driver rolls around...

Copy link
Collaborator

@veyndan veyndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sproctor as you added initial support for this in #3843

The sqljs driver is going bye bye and the paging extension currently does not support the web-worker-driver.
@dellisd dellisd merged commit 6591d9f into master Sep 27, 2023
7 checks passed
@dellisd dellisd deleted the paging-js-tests branch September 27, 2023 21:53
hfhbd pushed a commit that referenced this pull request Apr 2, 2024
* Remove js tests from androidx-paging3

The sqljs driver is going bye bye and the paging extension currently does not support the web-worker-driver.

* Restore JS test sources to satisfy compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants