-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 5040 PostgreSql json operators #5041
Merged
hfhbd
merged 10 commits into
cashapp:master
from
griffio:fix-5040-postgresql-json-operators
Mar 27, 2024
Merged
Fixes 5040 PostgreSql json operators #5041
hfhbd
merged 10 commits into
cashapp:master
from
griffio:fix-5040-postgresql-json-operators
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
changed the title
Fix 5040 PostgreSql json operators
Fixes 5040 PostgreSql json operators
Feb 28, 2024
Add Json Path operator to grammar Add jsonExpression to return JSON type in resolver Add Integration Tests
Any operators starting with "?" must be escaped with an prefix "?" for binding with JDBC statements. This means that SQL statements must use e.g "??"
Either Boolean or JSON
Tests for operators
JsonExpressionMixin.kt
previous tests were not valid
Fixture tests Integration tests
griffio
force-pushed
the
fix-5040-postgresql-json-operators
branch
from
March 20, 2024 07:48
a359863
to
d8fd1c2
Compare
Use the Json type so that the bind parameters use setObjectOther Add integration tests
hfhbd
approved these changes
Mar 27, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Initial changes for json operators Add Json Path operator to grammar Add jsonExpression to return JSON type in resolver Add Integration Tests * Add boolean operators to grammar Any operators starting with "?" must be escaped with an prefix "?" for binding with JDBC statements. This means that SQL statements must use e.g "??" * Discriminate operator return type Either Boolean or JSON * Integration tests Tests for operators * Fixture Test * Remove "'||' | '-'" operators for now JsonExpressionMixin.kt * Fixture tests previous tests were not valid * Support Json for "||" "-" operators * Add tests for operators Fixture tests Integration tests * fix json functions Use the Json type so that the bind parameters use setObjectOther Add integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5040
🚧 🍔 based on branch
griffio:fix-5028-postgresql-json
as requires JSON typeAdds Json Path operator to grammar
Adds jsonExpression to return JSON type in resolver
Adds Integration Tests - json functions
Note:
?
'?|'?&' operators require the Sql statement to use an additional ?
see https://jdbc.postgresql.org/documentation/query/#using-the-statement-or-preparedstatement-interface||
,-
JSON type used with existing operatorsFix json functions to allow Json type binding with
setObjectOther