Fixes json operator binding for 5040 #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use column_expr instead of column_name as this allows a binary expression to be evaluated JsonExpressionMixin now references a column_expr
dellisd
approved these changes
Mar 30, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Fix json_expression use column_expr instead of column_name as this allows a binary expression to be evaluated JsonExpressionMixin now references a column_expr * Add integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📟 Follow up from PR #5041
Added the binary operator expressions support
Added Integration tests for binary operator binding
e.g
👐 This required making the json expression use a column expression with the json operator so that a sql expression is evaluated