Fix 5345 PostgreSql SELECT DISTINCT ON #5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update DistinctOnExpressionMixin.kt - expose missing tables Query the columns or any tables prefixing columns in the distinctOn clause As there could be one or more columns with the same table prefix, remove any duplicates
griffio
force-pushed
the
fix-5345-postgresql-distinct-on
branch
from
659a30d
to
e182037
Compare
JakeWharton
approved these changes
Jul 16, 2024
...n/kotlin/app/cash/sqldelight/dialects/postgresql/grammar/mixins/DistinctOnExpressionMixin.kt
Outdated
Show resolved
Hide resolved
As the code is was using mapNotNull Remove unnecessary null type parameter and not-null assertion operator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5345
Update DistinctOnExpressionMixin to expose tables (if prefix present) or use previous code that exposes columns
Update fixture test to include queries with multiple tables and columns
Add Integration test to validate compiled queries and prevent regressions