Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5345 PostgreSql SELECT DISTINCT ON #5353

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Fix 5345 PostgreSql SELECT DISTINCT ON #5353

merged 3 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. Update DistinctOnExpressionMixin.kt 

    Update DistinctOnExpressionMixin.kt - expose missing tables

Query the columns or any tables prefixing columns in the distinctOn clause

As there could be one or more columns with the same table prefix, remove any duplicates
    @griffio
    griffio committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a7f249a View commit details
    Browse the repository at this point in the history

  2. Add tests 

    fixture tests - multiple tables and columns in DISTINCT ON
integration test - valid sql is generated and helps prevent regressions
    @griffio
    griffio committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e182037 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Remove unnecessary nullability 

    As the code is was using mapNotNull
Remove unnecessary null type parameter and not-null assertion operator
    @griffio
    griffio committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7550327 View commit details
    Browse the repository at this point in the history