fix: mossberg 590A1 no longer has obsoleted gunmods installed on it #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
#4179 obsoleted mount slots for guns, but one gun still had mount slots pre-installed on them, which in practice gave them 2 sight and underbarrel slots since the game happily ignored the fact that the mods no longer have a slot they fit on and instead just applied the effects of those mount mods without a second though.
Describe the solution
Removed the mount slot
default_modsfrom the mossberg 590A1.Describe alternatives you've considered
screm
Testing
Used my eyes to confirm the line I deleted no longer exists.
Additional context
Checklist