feat(content, port): port treetops and ability to climb trees from DDA

[ethanmeade]

Checklist

Required

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax so it can be closed automatically.
• I have committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

Optional

Purpose of change

Ports over the ability to climb trees from DDA as implemented here. This does not port over the mutation changes regarding that PR; it also does not include tiles for the treetops themselves.

Describe the solution

Cherry-picked the code and JSON changes from the DDA PR to this code-base. This includes the addition of four new "treetop" terrains to the terrain-roofs JSON file and modifications of the tree entries in the terrain-flora JSON file. It also implements two new terrain flags: SINGLE_SUPPORT, which causes the terrain to be destroyed if the support under it is removed, even if there are adjacent supports, and CLIMB_ADJACENT, which allows the player to climb the terrain while standing adjacent to it.

Describe alternatives you've considered

Rewriting the code from scratch instead of porting it over from DDA. Alternatively, implementing no changes.

Testing

• Generate a world with new trees
• Climb tree without throwing an exception / generating errors
• Climb down from tree without generating errors
• Fall off of tree
• Cut down a tree and check that the treetop is destroyed with it
  • Cut down a tree with supporting walls nearby and confirm that treetop is still destroyed

Additional context

[ethanmeade]

Currently, the game generates the world but throws errors while doing so. Actually attempting to climb a tree results in a crash. Working on debugging it now.

[scarf005]

issue

this part crashes the vertical move code.

1. cost is of type const std::optional<int>, and attempting to get value when it's empty throws exception. you need to check it does has value using cost.has_value below.
2. originally, it made an early return if cost was empty in the below code block.
3. however, in the new condition, the code block will not get executed when cost.has_value() == false and adjacent_climb == true
4. which means it skips cost validation in https://github.com/ethanmeade/cataclysm-bn-local/blob/25b13fdb0aac0cb6d3a9ffc48ea6509198ab2acc/src/game.cpp#L10077 , hence the crash

possible solution

make sure cost is validated before getting evaluated.

[ethanmeade]

Changed the trees to use the current CLIMBABLE terrain flag rather than the ported-over CLIMBABLE_ADJACENT terrain flag. Now it no longer crashes! Some issues do remain though: explicitly cutting a tree down does not remove the treetop, and when the treetop is removed it leaves behind an ASCII air tile rather than the normal graphical tile.

I'm not sure how difficult the trees should be to climb / move between, but I'm open to discussions on how that should be adjusted.

Edit: I most likely remove all references to the CLIMBABLE_ADJACENT tag in a future commit before taking this out of draft, assuming no reason for using it comes up during this PR.

[ethanmeade]

So now treetops collapse whenever their parent tree is cutdown, but adjacent treetops also seem to collapse upon this happening, even if their parent trees are out of the way of the felled tree.

Amusingly enough, this behavior appears to also occur in DDA. Nevertheless, it doesn't seem that desirable, so I'm looking into preventing it.

[KheirFerrum]

SINGLE_SUPPORT flag is unnecessary, all behaviour is functionally identical with and without it. Roof's will still randomly collapse with changes made. Previous commit I did has removed the ability for roofs to collapse if they are supported by walls underneath. It also explains the edge case with this that wouldn't be resolved by SINGLE_SUPPORT as it is now but also doesn't actually need to be "fixed" in my opinion.

Please remove SINGLE_SUPPORT in light of this to prevent code from becoming more complex for no benefit.

Loading game also causes all treetops to trip JSON checks for bash_below, please append a "bash" field to your treetops. I suggest using the glass or paper roof as the basis of str_max and str_min

Finally, please make sure you remove flags that are no longer being used. CLIMBABLE_ADJACENT seems to have been deprecated by you for CLIMBABLE, so make sure to remove that from mapdata.h

[KheirFerrum]

Made a number of changes to the code and json. Should be ready for merging.
There's an unrelated issue where collapsed rooves form open air that displays as a placeholder instead of being transparent, but that bug is out of scope for this PR.

[scarf005]

@chaosvolt could you playtest this once more?

[ethanmeade]

Sorry about not contributing further, got sidetracked and forgot about this. Let me know if there's anything I can do to help - although it looks like its already been handled outside of the play testing

[RoyalFox2140]

Compiled. Load Tested.

Climbing lone and multiple treetops works, smashing wood chopping and trees colliding into each other on wood chopping all works as intended.

Roof collapse on wall and floor destruction works as it used to even though this still means its inconsistent and allows for islands. Everything works and roof collapse sucking is out of scope.

[KheirFerrum]

Sorry about not contributing further, got sidetracked and forgot about this. Let me know if there's anything I can do to help - although it looks like its already been handled outside of the play testing

No issue, it's mostly done now, not a lot of the C++ side remains from DDA's implementation, and the JSON side has seen extensive modification, but hell, it's not the first time we've had PRs end up being loosely inspired.

I mostly only looked at it since someone raised it in dev chat and I had a small amount of time on my hands