-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Treetops even should Github bar the way #70669
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gkarfakis19 was worried about this being an unbalancing change. For reasons outlined in the comments below the old PR, I don't think it will be, however an idea struck me. Once #70479 is merged, it'll add a stagger effect that can make the player stumble in a random direction. I will roll in a check to make this happen randomly when you have the bouldering effect, pending the merge of that PR and a fix for #70644 . So if you're doing spear cheese on a roof or a treetop and you miss, you'll have a chance of falling off. |
The ultimate solution to spear cheese is to remove ability to attack other z levels at least from normal reach attack. We assume 4 meter height difference between levels, you don't poke that distance usefully with those weapons. But that doesn't need to block this PR in any way. |
It is very weird that we block monsters from grabbing up Z diagonals but allow players to stab down them. |
Summary
Features "Adds treetops and makes trees climbable"
Purpose of change
Our trees are big enough to block all movement through their tile, but weren't climbable.
Describe the solution
Describe alternatives you've considered
Out of scope for now, but it probably wouldn't be too hard to make trees have variable heights. Then you'd scale them with something like the WALL_CLING ability that would be available to anyone, so z+1 would be you clinging to the side of the trunk, and at z+2 you'd be on the treetop, etc.
Making it so that some types of trees aren't climbable, or are only climbable with special equipment or mutation flags would also be easy.
There are only 4 forms of treetops right now, and they're all identical except their colors. The base kind is for all deciduous trees, evergreen, dead, and mega_fern are obviously for trees fitting those descriptions. I'm assuming this will be enough for spriters. If not, it's trivial to add more types of treetops in future PRs.
Testing
Additional context