Fix extraction of background image URLs. #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * added support for other types of non-src images * fixed edge-side processing of the LCP events * Moved the edge-processing to before the debug log gets collected (so logs can be included) For catchpoint/WebPageTest#2455
stoyan
approved these changes
Oct 11, 2022
| if (style.backgroundImage && style.backgroundImage != 'none') { | ||
| event.element['background-image'] = style.backgroundImage; | ||
| } | ||
| if (style.content && style.content != 'none') { |
There was a problem hiding this comment.
Curious how do we use this? Because it can be a whole bunch of stuff other than none, I wonder why we filter out none
There was a problem hiding this comment.
'none' is the default value that gets populated when it's not explicitly set. https://developer.mozilla.org/en-US/docs/Web/CSS/background-image#syntax
tkadlec
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
For catchpoint/WebPageTest#2455