Add support to LCP vitals page for "url" based LCP images #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where images aren't regular src or background images and properly highlights the image request. Example [here](https://wpt.meenan.us/vitals.php?test=221011_9A_T&run=1&cached=0#lcp). This doesn't update the experiments code to be aware of the 'url'-based LCP images which still needs to be done. For catchpoint#2455
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where images aren't regular src or background images and properly highlights the image request. Example here.
This doesn't update the experiments code to be aware of the 'url'-based LCP images which still needs to be done.
For #2455
This goes with the client change in catchpoint/WebPageTest.agent#576