Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: env and secrets + test: front-to-end #65

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

gordonkoehn
Copy link
Collaborator

@gordonkoehn gordonkoehn commented Dec 20, 2024

This PR closes #64.

Actually also closes #66.

@gordonkoehn gordonkoehn self-assigned this Dec 20, 2024
@gordonkoehn gordonkoehn linked an issue Dec 20, 2024 that may be closed by this pull request
@gordonkoehn gordonkoehn changed the title refactor: env and secrets refactor: env and secrets + test: front-to-end Dec 20, 2024
@gordonkoehn gordonkoehn marked this pull request as ready for review December 20, 2024 10:56
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 10:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .env.example: Language not supported
  • docker-compose.env: Language not supported
Comments suppressed due to low confidence (1)

docker-compose.yml:11

  • The line contains a mistake. It should be corrected to - ./scripts/reference_genomes.json:/app/scripts/reference_genomes.json.
- ./scripts/reference_genomes.json:/app/scripts/- ./scripts/database_config.yaml:/app/scripts/reference_genomes.json

README.md Outdated Show resolved Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gordonkoehn gordonkoehn merged commit ca078e6 into main Dec 20, 2024
2 checks passed
@gordonkoehn gordonkoehn deleted the refactor/env-secrets branch December 20, 2024 11:58
gordonkoehn added a commit that referenced this pull request Dec 20, 2024
* refactor: env and secrets

* refactor: add github action to run in CI

* fix docker secrets

* run this actually

* Update README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Gordon J. Köhn <gordon.koehn@dbsse.ethz.ch>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Start-to-End Test Remove AWS secrets from docker compose envs / move to .env
1 participant