Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Include x_min and y_min in OpDomain and check non-emptyness of vector before accessing element. #407

Merged
merged 19 commits into from
Apr 16, 2024

:art: revert unit test changes.

b6278e8
Select commit
Loading
Failed to load commit list.
Merged

🐛 Include x_min and y_min in OpDomain and check non-emptyness of vector before accessing element. #407

:art: revert unit test changes.
b6278e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 16, 2024 in 0s

98.34% (target 95.00%)

View this Pull Request on Codecov

98.34% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.34%. Comparing base (5472969) to head (b6278e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   98.34%   98.34%   -0.01%     
==========================================
  Files         210      210              
  Lines       28040    28091      +51     
  Branches     1280     1285       +5     
==========================================
+ Hits        27576    27625      +49     
- Misses        464      466       +2     
Files Coverage Δ
...fiction/technology/charge_distribution_surface.hpp 99.37% <100.00%> (+<0.01%) ⬆️
.../algorithms/simulation/sidb/operational_domain.cpp 100.00% <100.00%> (ø)
.../algorithms/simulation/sidb/operational_domain.hpp 96.77% <82.35%> (-0.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5472969...b6278e8. Read the comment docs.