Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix compilation of Python wheels for Windows #462

Closed
wants to merge 53 commits into from

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Jun 20, 2024

Description

Github has released an update to MSVC v144 for the windows-latest runner. This could cause this problem as discussed here. So we have to use windows-2019 until this is fixed.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok marked this pull request as draft June 20, 2024 07:39
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (86ec324) to head (71560f1).
Report is 66 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         214      214           
  Lines       28876    28877    +1     
  Branches     1367     1367           
=======================================
+ Hits        28361    28362    +1     
  Misses        515      515           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ec324...71560f1. Read the comment docs.

@Drewniok Drewniok changed the title 💚 try to fix wheel test issue on windows. 💚 Use Windows-2019 for CI Builds. Jun 27, 2024
@Drewniok Drewniok self-assigned this Jun 27, 2024
@Drewniok Drewniok added the github_actions Pull requests that update GitHub Actions code label Jun 27, 2024
@Drewniok Drewniok marked this pull request as ready for review June 27, 2024 07:43
@Drewniok Drewniok requested a review from marcelwa June 27, 2024 07:54
@Drewniok Drewniok changed the title 💚 Use Windows-2019 for CI Builds. 💚 Update windows CI. Jun 27, 2024
@Drewniok Drewniok changed the title 💚 Update windows CI. 💚 Update Windows CI. Jun 27, 2024
@marcelwa marcelwa changed the title 💚 Update Windows CI. 💚 Fix compilation of Python wheels for Windows Jun 27, 2024
@Drewniok Drewniok closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants