windows-latest MSVC compiler crashes

[elalish]

Description

This Action worked fine for our last release a few months back on v2.16, but now fails 100% (only on Windows - still works fine on Linux and MacOS) on both v2.16 and v2.19. It's very helpfully giving us this:

Error: Command python D:\a\manifold\manifold/bindings/python/examples/run_all.py failed with code 3221225477. 

Build log

https://github.com/elalish/manifold/actions/runs/9487313229/job/26143641015

CI config

https://github.com/elalish/manifold/blob/fixPyPI2/.github/workflows/build_wheels.yml

[henryiii]

Try windows-2019, just a hunch.

[henryiii]

(GitHub updated to MSVC v144 about 5-7 days ago and I've seen some things falling. The windows-2019 images don't have the new MSVC)

[elalish]

Excellent, thank you - looks like that fixed it! I'll keep an eye on this issue to see when we can return to windows-latest.

[maxbachmann]

@henryiii I would like my library to require only the C++ redistributable that ships alongside CPython. Currently I am using windows-latest as well, but this can lead to a newer C++ redistributable being required. This can lead to issues (e.g. the current upgrade leads to crashes in std::mutex). I can solve this by using windows-2019 or specifying _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR.

I think it would be useful if there was a feature in scikit-build/cibuildwheel which errors out when a compiler is used that would lead to a different C++ redistributable being required.

[henryiii]

I believe this would be a feature request for devlewheel. (and you'd need to specify devlewheel manually still, we don't do it automatically yet, it' just a recommendation).

[joerick]

for reference: delvewheel