-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💚 Fix compilation of Python wheels for Windows #465
Merged
marcelwa
merged 53 commits into
cda-tum:dependabot/submodules/submodules-3b6f34c3bb
from
Drewniok:fix_wheel_test_issue_windows
Jun 28, 2024
Merged
💚 Fix compilation of Python wheels for Windows #465
marcelwa
merged 53 commits into
cda-tum:dependabot/submodules/submodules-3b6f34c3bb
from
Drewniok:fix_wheel_test_issue_windows
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix_wheel_test_issue_windows
Drewniok
changed the title
Fix wheel test issue windows
💚 Fix compilation of Python wheels for Windows
Jun 28, 2024
marcelwa
merged commit Jun 28, 2024
53bd8a2
into
cda-tum:dependabot/submodules/submodules-3b6f34c3bb
55 of 60 checks passed
marcelwa
added a commit
that referenced
this pull request
Jun 28, 2024
* ⬆️ Bump the submodules group across 1 directory with 5 updates Bumps the submodules group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [libs/alice](https://github.com/marcelwa/alice) | ``544577f`` | ``a55415e`` | | [libs/parallel-hashmap](https://github.com/greg7mdp/parallel-hashmap) | ``1036816`` | ``d88c5e1`` | | [libs/tinyxml2](https://github.com/leethomason/tinyxml2) | ``312a809`` | ``a0f66fd`` | | [libs/pybind11](https://github.com/pybind/pybind11) | ``b07fddb`` | ``7c4ac91`` | | [libs/mockturtle](https://github.com/lsils/mockturtle) | ``b7fe3a7`` | ``bfcee23`` | Updates `libs/alice` from `544577f` to `a55415e` - [Commits](marcelwa/alice@544577f...a55415e) Updates `libs/parallel-hashmap` from `1036816` to `d88c5e1` - [Release notes](https://github.com/greg7mdp/parallel-hashmap/releases) - [Commits](greg7mdp/parallel-hashmap@1036816...d88c5e1) Updates `libs/tinyxml2` from `312a809` to `a0f66fd` - [Release notes](https://github.com/leethomason/tinyxml2/releases) - [Commits](leethomason/tinyxml2@312a809...a0f66fd) Updates `libs/pybind11` from `b07fddb` to `7c4ac91` - [Release notes](https://github.com/pybind/pybind11/releases) - [Commits](pybind/pybind11@b07fddb...7c4ac91) Updates `libs/mockturtle` from `b7fe3a7` to `bfcee23` - [Release notes](https://github.com/lsils/mockturtle/releases) - [Commits](lsils/mockturtle@b7fe3a7...bfcee23) --- updated-dependencies: - dependency-name: libs/alice dependency-type: direct:production dependency-group: submodules - dependency-name: libs/parallel-hashmap dependency-type: direct:production dependency-group: submodules - dependency-name: libs/tinyxml2 dependency-type: direct:production dependency-group: submodules - dependency-name: libs/pybind11 dependency-type: direct:production dependency-group: submodules - dependency-name: libs/mockturtle dependency-type: direct:production dependency-group: submodules ... Signed-off-by: dependabot[bot] <support@github.com> * 💚 Remove fmt from the macOS runners via homebrew because of clashes with alice * 👷 Remove more unused packages when cleaning up before CodeQL * 👷 Guess fmt was not installed via brew * 💚 Remove fmt manually if found * Fix formatter const correctness * Updated alice version * ⬆️ Update mockturtle to my own fork that contains library adjustments and bug fixes * ⬆️ Fix branch * ⬆️ Update mockturtle to include fix for JSON formatting * ✅ Adjusted test cases to new {fmt} version * 💚 Fix compilation of Python wheels for Windows (#465) * 💚 try to fix wheel test issue on windows. * 💚 conduct renaming. * 💚 use normal threads instead of ``std::future``. * 💚 update test. * 💚 trial and error. * 💚 delete thread count option. * 🎨 Incorporated pre-commit fixes * 💚 delete thread count option. * 💚 trial and error. * 💚 only one thread. * 💚 small changes in multithreading. * 💚 use ``future`` for multithreading. * 💚 use sanitizer. * 💚 revert use of sanitizer. * 🎨 revert changes. * 🎨 using old quicksim code * 💚 use windows-2019. * 💚 revert code changes. * 💚 using windows-2019. * 💚 remove ``*-latest`` and use toolsets. * 💚 use toolsets. * 💚 update toolsets. * 💚 delete exclude part. * 💚 windows 2019. * 💚 remove toolset key. * 💚 use v143 for 2022. * 💚 use 2019. * :green_heart only using 2019. * 🎨 implement Marcel's comments. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcel Walter <marcel.walter@tum.de> Co-authored-by: Jan Drewniok <97012901+Drewniok@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github has released an update to MSVC v144 for the
windows-latest
runner. This can cause problems as discussed here. So we have to usewindows-2019
until this is fixed.Checklist: