Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove ECC framework #667

Merged
merged 1 commit into from
Aug 12, 2024
Merged

🔥 remove ECC framework #667

merged 1 commit into from
Aug 12, 2024

Conversation

burgholzer
Copy link
Member

Description

This is the pendant to cda-tum/mqt-qecc#256 and removes the ECC framework from MQT Core.
This mostly slims down the MQT Core library a little and eliminates hardly maintained code.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

the framework has been upstreamed to the QECC repository

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added usability Anything related to usability refactor Anything related to code refactoring Core Anything related to the Core library and IR c++ Anything related to C++ code labels Aug 12, 2024
@burgholzer burgholzer self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.7%. Comparing base (5802520) to head (a47f234).
Report is 120 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #667    +/-   ##
======================================
  Coverage   91.7%   91.7%            
======================================
  Files        148     133    -15     
  Lines      14832   14106   -726     
  Branches    2386    2212   -174     
======================================
- Hits       13603   12945   -658     
+ Misses      1229    1161    -68     
Flag Coverage Δ
cpp 91.5% <ø> (+<0.1%) ⬆️
python 99.7% <ø> (ø)

see 4 files with indirect coverage changes

@burgholzer burgholzer merged commit 9ddee9e into main Aug 12, 2024
34 checks passed
@burgholzer burgholzer deleted the remove-ecc-framework branch August 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR refactor Anything related to code refactoring usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant