Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 transfer the ECC framework code from MQT Core #256

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR moves the ECC (framework) related code from MQT Core to this repository.
It is hard to maintain in MQT Core and feels like an alien there.
Much better suited in this library.

A corresponding PR in MQT Core will remove the respective functionality there.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added usability Anything related to usability refactor Changes the refactor the code base labels Aug 12, 2024
@burgholzer burgholzer self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 87.68606% with 91 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (ae9e1de) to head (b732433).
Report is 132 commits behind head on main.

Files with missing lines Patch % Lines
src/ecc/Q7Steane.cpp 80.0% 28 Missing ⚠️
src/ecc/Q3Shor.cpp 83.1% 15 Missing ⚠️
src/ecc/Q9Shor.cpp 90.6% 12 Missing ⚠️
src/ecc/Q18Surface.cpp 89.0% 10 Missing ⚠️
src/ecc/Q9Surface.cpp 91.0% 10 Missing ⚠️
src/ecc/Q5Laflamme.cpp 90.8% 9 Missing ⚠️
include/ecc/Ecc.hpp 92.5% 2 Missing ⚠️
src/ecc/Ecc.cpp 91.3% 2 Missing ⚠️
include/ecc/Q3Shor.hpp 66.6% 1 Missing ⚠️
include/ecc/Q5Laflamme.hpp 75.0% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #256     +/-   ##
=======================================
+ Coverage   82.2%   83.3%   +1.0%     
=======================================
  Files         29      44     +15     
  Lines       3138    3877    +739     
  Branches     180     362    +182     
=======================================
+ Hits        2581    3231    +650     
- Misses       557     646     +89     
Flag Coverage Δ
cpp 82.7% <87.6%> (+4.4%) ⬆️
python 83.7% <ø> (ø)
Files with missing lines Coverage Δ
include/ecc/Id.hpp 100.0% <100.0%> (ø)
include/ecc/Q18Surface.hpp 100.0% <100.0%> (ø)
include/ecc/Q7Steane.hpp 100.0% <100.0%> (ø)
include/ecc/Q9Surface.hpp 100.0% <100.0%> (ø)
include/ecc/Q3Shor.hpp 66.6% <66.6%> (ø)
include/ecc/Q5Laflamme.hpp 75.0% <75.0%> (ø)
include/ecc/Q9Shor.hpp 75.0% <75.0%> (ø)
include/ecc/Ecc.hpp 92.5% <92.5%> (ø)
src/ecc/Ecc.cpp 91.3% <91.3%> (ø)
src/ecc/Q5Laflamme.cpp 90.8% <90.8%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

burgholzer added a commit to cda-tum/mqt-core that referenced this pull request Aug 12, 2024
## Description

This is the pendant to cda-tum/mqt-qecc#256 and
removes the ECC framework from MQT Core.
This mostly slims down the MQT Core library a little and eliminates
hardly maintained code.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit 01b6d75 into main Aug 12, 2024
27 of 28 checks passed
@burgholzer burgholzer deleted the vendor-ecc-framework branch August 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes the refactor the code base usability Anything related to usability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant