Add --target-face-num parameter to ReconstructMesh #671

pierotofy · 2021-04-26T14:40:09Z

Hello ✋

This PR proposes the following additions/changes:

Add a --target-face-num parameter to ReconstructMesh. Sometimes a target number of faces is known/desired and can sometimes work better for a user than using the --decimate parameter, which is a function of the number of existing faces.
Fixes the logic in ReconstructMesh to allow the usage of --mesh-file without passing an openMVS project. Currently a user needs to always pass an input project (see line 177 and 230 of ReconstructMesh.cpp).

Please let me know if changes are needed? 🙏

cdcseacave · 2021-04-26T16:20:08Z

apps/ReconstructMesh/ReconstructMesh.cpp

@@ -61,6 +61,7 @@ bool bUseFreeSpaceSupport;
 float fThicknessFactor;
 float fQualityFactor;
 float fDecimateMesh;
+int iTargetFaceNum;


pls use unsigned instead of int as it never takes negative values

cdcseacave · 2021-04-26T16:22:00Z

apps/ReconstructMesh/ReconstructMesh.cpp

@@ -167,12 +169,12 @@ bool Initialize(size_t argc, LPCTSTR* argv)
 	// validate input
 	Util::ensureValidPath(OPT::strInputFileName);
 	Util::ensureUnifySlash(OPT::strInputFileName);
-	if (OPT::vm.count("help") || OPT::strInputFileName.IsEmpty()) {
+	if (OPT::vm.count("help") || (OPT::strInputFileName.IsEmpty() && OPT::strMeshFileName.IsEmpty())) {


I'd implement this differently:
pass the mesh file as the input instead as using --mesh-file param, and at the scene loading time you have an import option which if set on true, it allows to load a mesh too instead of only MVS

Hey @cdcseacave, thanks for the feedback. Could you expand more on this one?

at the scene loading time you have an import option which if set on true

Is this an additional flag? Could one just check for the file extension instead too? (If it's MVS, load scene, if it's OBJ/PLY, load mesh).

Does --mesh-file have another purpose then?

cdcseacave · 2021-04-26T16:22:47Z

apps/ReconstructMesh/ReconstructMesh.cpp

-		scene.mesh.Clean(OPT::fDecimateMesh, OPT::fRemoveSpurious, OPT::bRemoveSpikes, OPT::nCloseHoles, OPT::nSmoothMesh, false);
-		scene.mesh.Clean(1.f, 0.f, OPT::bRemoveSpikes, OPT::nCloseHoles, 0, false); // extra cleaning trying to close more holes
-		scene.mesh.Clean(1.f, 0.f, false, 0, 0, true); // extra cleaning to remove non-manifold problems created by closing holes
+		scene.mesh.Clean(OPT::fDecimateMesh, OPT::fRemoveSpurious, OPT::bRemoveSpikes, OPT::nCloseHoles, OPT::nSmoothMesh, false, OPT::iTargetFaceNum);


combine iTargetFaceNum and fDecimateMesh, by converting the new param in the existing one by computing the desired ratio

cdcseacave · 2021-04-26T16:23:50Z

Good idea, but pls address the small suggestions I found.

cdcseacave · 2021-04-27T13:16:42Z

pls see the function definition:

openMVS/libs/MVS/Scene.h

Line 78 in 281d86a

bool Load(const String& fileName, bool bImport=false);

pierotofy · 2021-04-27T14:06:11Z

pls use unsigned instead of int as it never takes negative values

✔️

combine iTargetFaceNum and fDecimateMesh, by converting the new param in the existing one by computing the desired ratio

✔️

pass the mesh file as the input instead as using --mesh-file param

❌ this doesn't seem to work, as the logic in https://github.com/cdcseacave/openMVS/blob/develop/apps/ReconstructMesh/ReconstructMesh.cpp#L291-L301 overrides the loaded mesh. I left the use of the --mesh-file parameter instead. Passing both -i and --mesh-file is inefficient because it leads to loading the mesh twice.

cdcseacave · 2021-04-27T15:02:41Z

maybe I misunderstood, I thought the goal is to load a mesh to clean/decimate only
if that is the case, what I suggested is what you need, and you just need to add also scene.mesh.IsEmpty() check here

openMVS/apps/ReconstructMesh/ReconstructMesh.cpp

Line 251 in 0f2a5a0

if (OPT::strMeshFileName.IsEmpty()) {

pierotofy · 2021-04-27T15:38:47Z

I thought the goal is to load a mesh to clean/decimate only

It is.

With this PR, I can do:

OpenMVS/ReconstructMesh --mesh-file mesh.ply -o clean.ply --target-face-num 10000000

I get that you're trying to recommend to use the -i flag so that we could do:

OpenMVS/ReconstructMesh -i mesh.ply -o clean.ply --target-face-num 10000000

I don't know or I'm not understanding how you want me to code this, but feel free to edit as you see fit.

cdcseacave · 2021-04-27T19:56:51Z

I've edited the file as I see it. I did not test it, changed it directly on github, but should be close to working. It should work by running:

ReconstructMesh mesh.ply -o clean.ply --target-face-num 10000000

pierotofy · 2021-04-27T19:59:38Z

Thanks @cdcseacave ! I'll test sometimes tomorrow and report back. 🙏

pierotofy · 2021-04-28T18:01:10Z

Tested, and works great! 👍

cdcseacave · 2021-04-29T06:54:06Z

Cool, I'll merge it then. Thank you, Piero!

* dense: add image mask support * dense: fix bug in mask application * build: update find packages * build: fix usage as third-party library * interface: export and compare camera poses with an OpenMVG refined version * interface: export MVS scene to NVM format * common: fix camera scaling * dense: small code refactor * mvs: view DMAPs with different resolution * interface: replace define with constexp * interface: small change * common: fix PFM exporter/importer * common: disable CPUID on ARM platforms * dense: add Region-Of-Interest (ROI) support * common: improve octree speed * build: update AppVeyor * mesh: split mesh in sub-meshed by max area * dense: split scene in sub-scenes * cmake: build libCommon/IO/Math as shared if BUILD_SHARED_LIBS=ON (#650) * mesh: fix bug in RemoveFaces() * dense: filter more redundant views from sub-scenes * common: add ZSTD serialization support * apps: set internal linkage for functions and variables (#656) * common: small refactor * mesh: raster triangles using barycentric coordinates * remove cotire * dense: merge small sub-scenes * interface: import COLMAP depth-maps * interface: add MVS preset to the python script * interface: fix COLMAP on linux * common: make binary projects portable * viewer: display views seeing selected point or points seen by the current view * dense: improve depth-map initialization * dense: merge depth-maps (no fusion) * interface: add similarity transform functionality * common: fix file permissions on linux * mesh: add GLTF writing support * mesh: add target-face-num parameter to ReconstructMesh (#671) * mesh: improve GLTF support * dense: add geometric-consistency * dense: fix for invalid images (cherry picked from commit b29648f835e5ee0b36b4240a160a20124001f34d) * dense: close file in reading invalid depth-map (#685) * dense: export point-cloud with min number of views per point (cherry picked from commit 9b6b2fd7ec89a5b7ea3acdef83664daccbfc8c03) * dense: detect computed depth-maps (cherry picked from commit 52f9162874e4c3da66bb618dcea9dddc1bdf644a) * refine: initialize image neighbors from input mesh (cherry picked from commit 2a069fa0856582da2b766ba85091d3e46fa783de) * dense: select better angle neighbors (cherry picked from commit 05a49551ad13873c664bf394d4584cf5c44f198c) * dense: patch-match implemented in CUDA (faster & better) * common: fix latest boost * dense: expose --cuda-device option (#707) * build: add Dockerfile for CUDA #710 * dense: fix bug in selecting views (cherry picked from commit d068c02295234199f49b26afc85ac643886f2311) * build: fix CUDA for older cards (#712) * dense: fix small clusters (#702) * interface: fix COLMAP log export * interface: add Metashape and predefined neighbors list support * interface: fix compile linux * dense: add support for scenes with empty point-cloud but known (coarse) mesh * dense: filter low score estimates * interface: add Metashape ROI support * viewer: display ROI * dense: increase NCC threshold for CUDA * interface: remap Metashape indices * dense: fix depth-map crash in CUDA * interface: update MVG-MVS pipeline Co-authored-by: YOSHIFUJI Naoki <lwisteria.ao@gmail.com> Co-authored-by: Piero Toffanin <pt@masseranolabs.com> Co-authored-by: Tommy Bojanin <Bojanint@gmail.com>

* dense: add image mask support * dense: fix bug in mask application * build: update find packages * build: fix usage as third-party library * interface: export and compare camera poses with an OpenMVG refined version * interface: export MVS scene to NVM format * common: fix camera scaling * dense: small code refactor * mvs: view DMAPs with different resolution * interface: replace define with constexp * interface: small change * common: fix PFM exporter/importer * common: disable CPUID on ARM platforms * dense: add Region-Of-Interest (ROI) support * common: improve octree speed * build: update AppVeyor * mesh: split mesh in sub-meshed by max area * dense: split scene in sub-scenes * cmake: build libCommon/IO/Math as shared if BUILD_SHARED_LIBS=ON (#650) * mesh: fix bug in RemoveFaces() * dense: filter more redundant views from sub-scenes * common: add ZSTD serialization support * apps: set internal linkage for functions and variables (#656) * common: small refactor * mesh: raster triangles using barycentric coordinates * remove cotire * dense: merge small sub-scenes * interface: import COLMAP depth-maps * interface: add MVS preset to the python script * interface: fix COLMAP on linux * common: make binary projects portable * viewer: display views seeing selected point or points seen by the current view * dense: improve depth-map initialization * dense: merge depth-maps (no fusion) * interface: add similarity transform functionality * common: fix file permissions on linux * mesh: add GLTF writing support * mesh: add target-face-num parameter to ReconstructMesh (#671) * mesh: improve GLTF support * dense: add geometric-consistency * dense: fix for invalid images (cherry picked from commit b29648f835e5ee0b36b4240a160a20124001f34d) * dense: close file in reading invalid depth-map (#685) * dense: export point-cloud with min number of views per point (cherry picked from commit 9b6b2fd7ec89a5b7ea3acdef83664daccbfc8c03) * dense: detect computed depth-maps (cherry picked from commit 52f9162874e4c3da66bb618dcea9dddc1bdf644a) * refine: initialize image neighbors from input mesh (cherry picked from commit 2a069fa0856582da2b766ba85091d3e46fa783de) * dense: select better angle neighbors (cherry picked from commit 05a49551ad13873c664bf394d4584cf5c44f198c) * dense: patch-match implemented in CUDA (faster & better) * common: fix latest boost * dense: expose --cuda-device option (#707) * build: add Dockerfile for CUDA #710 * dense: fix bug in selecting views (cherry picked from commit d068c02295234199f49b26afc85ac643886f2311) * build: fix CUDA for older cards (#712) * dense: fix small clusters (#702) * interface: fix COLMAP log export * interface: add Metashape and predefined neighbors list support * interface: fix compile linux * dense: add support for scenes with empty point-cloud but known (coarse) mesh * dense: filter low score estimates * interface: add Metashape ROI support * viewer: display ROI * dense: increase NCC threshold for CUDA * interface: remap Metashape indices * dense: fix depth-map crash in CUDA * interface: update MVG-MVS pipeline * increase version to 2.0.0 Co-authored-by: YOSHIFUJI Naoki <lwisteria.ao@gmail.com> Co-authored-by: Piero Toffanin <pt@masseranolabs.com> Co-authored-by: Tommy Bojanin <Bojanint@gmail.com>

pierotofy added 3 commits April 26, 2021 10:35

Add --target-face-num parameter to ReconstructMesh

1fafc0d

Style change

f14bb9d

Fix --help

281d86a

cdcseacave requested changes Apr 26, 2021

View reviewed changes

Simplify Clean function signature

0d7bba6

Update ReconstructMesh.cpp

b4e7811

cdcseacave added 2 commits April 29, 2021 09:50

Update Mesh.cpp

84aa0fa

Update ReconstructMesh.cpp

2c9c7cd

cdcseacave merged commit ecd5890 into cdcseacave:develop Apr 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --target-face-num parameter to ReconstructMesh #671

Add --target-face-num parameter to ReconstructMesh #671

pierotofy commented Apr 26, 2021 •

edited

Loading

cdcseacave Apr 26, 2021

cdcseacave Apr 26, 2021

pierotofy Apr 26, 2021 •

edited

Loading

cdcseacave Apr 26, 2021

cdcseacave commented Apr 26, 2021

cdcseacave commented Apr 27, 2021

pierotofy commented Apr 27, 2021 •

edited

Loading

cdcseacave commented Apr 27, 2021

pierotofy commented Apr 27, 2021

cdcseacave commented Apr 27, 2021 •

edited

Loading

pierotofy commented Apr 27, 2021

pierotofy commented Apr 28, 2021

cdcseacave commented Apr 29, 2021

Add --target-face-num parameter to ReconstructMesh #671

Add --target-face-num parameter to ReconstructMesh #671

Conversation

pierotofy commented Apr 26, 2021 • edited Loading

cdcseacave Apr 26, 2021

Choose a reason for hiding this comment

cdcseacave Apr 26, 2021

Choose a reason for hiding this comment

pierotofy Apr 26, 2021 • edited Loading

Choose a reason for hiding this comment

cdcseacave Apr 26, 2021

Choose a reason for hiding this comment

cdcseacave commented Apr 26, 2021

cdcseacave commented Apr 27, 2021

pierotofy commented Apr 27, 2021 • edited Loading

cdcseacave commented Apr 27, 2021

pierotofy commented Apr 27, 2021

cdcseacave commented Apr 27, 2021 • edited Loading

pierotofy commented Apr 27, 2021

pierotofy commented Apr 28, 2021

cdcseacave commented Apr 29, 2021

pierotofy commented Apr 26, 2021 •

edited

Loading

pierotofy Apr 26, 2021 •

edited

Loading

pierotofy commented Apr 27, 2021 •

edited

Loading

cdcseacave commented Apr 27, 2021 •

edited

Loading