run TinyTodo Go example in CI #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
go CI works as expected. Not sure why Java is failing, although I'm pretty sure it's not the fault of this PR. |
cdisselkoen
approved these changes
Sep 9, 2024
Comment on lines
+57
to
+60
| tinytodo-go: | ||
| uses: ./.github/workflows/build_tiny_todo_go_reusable.yml | ||
| with: | ||
| cedar_examples_ref: ${{ github.href }} |
There was a problem hiding this comment.
shouldn't this also need a ref of which commit of cedar-go to use? or is cedar-go CI not configured to run cedar-examples as a downstream?
There was a problem hiding this comment.
Based on this line, I believe that cedar-go is pinned to this commit. Added a comment to this effect for future reference.
cedar-go does not run this example in their CI -- I'll open an issue.
There was a problem hiding this comment.
New issue here: cedar-policy/cedar-go#30
aaronjeline
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Noticed that the CI for the Go example added in #182 wasn't actually running on PRs. Also noticed that an outdated file got added in that PR.