Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run TinyTodo Go example in CI #188

Merged
merged 3 commits into from
Sep 9, 2024
Merged

run TinyTodo Go example in CI #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83eb216
run TinyTodo Go example in CI
khieta Sep 9, 2024
ff6d399
remove unneeded dependency
khieta Sep 9, 2024
d4d42ca
add comment
khieta Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/build_tiny_todo_go_reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: Build and test TinyTodo-Go
on:
workflow_call:
inputs:
cedar_policy_ref:
required: true
type: string
cedar_examples_ref:
required: true
type: string
Expand Down
52 changes: 0 additions & 52 deletions .github/workflows/build_tiny_todo_reusable_go.yml
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ jobs:
cedar_policy_ref: refs/heads/${{ needs.get-branch-name.outputs.branch_name }}
cedar_examples_ref: ${{ github.href }}

tinytodo-go:
uses: ./.github/workflows/build_tiny_todo_go_reusable.yml
with:
cedar_examples_ref: ${{ github.href }}
Comment on lines +57 to +60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also need a ref of which commit of cedar-go to use? or is cedar-go CI not configured to run cedar-examples as a downstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this line, I believe that cedar-go is pinned to this commit. Added a comment to this effect for future reference.

cedar-go does not run this example in their CI -- I'll open an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue here: cedar-policy/cedar-go#30


build_and_run_oopsla_benchmarks:
name: OOPSLA2024 benchmarks
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion tinytodo-go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/cedar-policy/cedar-examples/tinytodo-go
go 1.22

require (
github.com/cedar-policy/cedar-go v0.0.0-20240715162045-a71e93ee6ae7
github.com/cedar-policy/cedar-go v0.0.0-20240715162045-a71e93ee6ae7 // pins the cedar-go commit
github.com/go-chi/chi/v5 v5.1.0
github.com/stretchr/testify v1.9.0
)
Expand Down
Loading