Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cedar entities validation. #206

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

amzn-mdamine
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR adds support for cedar-entity-validation.

  • Add entity validation in rust
  • Add entity validation in java
  • Add unit test in java and rust.

Similar to this: #202

Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just left some minor comments.

Copy link
Contributor

@shaobo-he-aws shaobo-he-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will re-approve it once the requested changes are implemented.

@khieta khieta merged commit 86e776f into cedar-policy:main Sep 17, 2024
4 checks passed
amzn-mdamine added a commit to amzn-mdamine/cedar-java that referenced this pull request Sep 17, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
amzn-mdamine added a commit to amzn-mdamine/cedar-java that referenced this pull request Sep 17, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
amzn-mdamine added a commit to amzn-mdamine/cedar-java that referenced this pull request Sep 17, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants