Add support for cedar entities validation. #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amzn-mdamine
force-pushed
the
release/3.3.x
branch
from
4223128
to
cec2c81
Compare
andrewmwells-amazon
approved these changes
Sep 11, 2024
shaobo-he-aws
approved these changes
Sep 11, 2024
amzn-mdamine
commented
Sep 11, 2024
CedarJava/src/test/java/com/cedarpolicy/EntityValidationTests.java
Outdated
Show resolved
Hide resolved
CedarJava/src/test/java/com/cedarpolicy/EntityValidationTests.java
Outdated
Show resolved
Hide resolved
khieta
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Changes look good 🙂
Remember to port this to release/3.4.x, release/4.0.x, and main as well. The first branch should be an easy cherry-pick. The latter two will require a little more effort since we've made changes to the code that this PR touches. I'd recommend putting up another PR for review against release/4.0.x.
CedarJava/src/test/java/com/cedarpolicy/EntityValidationTests.java
Outdated
Show resolved
Hide resolved
CedarJava/src/test/java/com/cedarpolicy/EntityValidationTests.java
Outdated
Show resolved
Hide resolved
amzn-mdamine
force-pushed
the
release/3.3.x
branch
from
4d00337
to
95bb11f
Compare
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
amzn-mdamine
force-pushed
the
release/3.3.x
branch
from
95bb11f
to
ec44c56
Compare
shaobo-he-aws
approved these changes
Sep 12, 2024
amzn-mdamine
added a commit
to amzn-mdamine/cedar-java
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
Merged
khieta
pushed a commit
that referenced
this pull request
Sep 13, 2024
Merged
shaobo-he-aws
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds support for cedar-entity-validation.
Refactor Entity json serialization similar to release/4.0.x