Cherry-pick #202 #208
Merged
Cherry-pick #202 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
approved these changes
Sep 17, 2024
|
I'm surprised CI is failing, since Cedar v4.0 should be very similar to the version on |
|
I'm looking into it. There seems to be some issues with the release branch. |
|
I have verified the build and tests locally, and everything is passing on my machine. However, it seems that the CI pipeline is still failing. I'll investigate further to identify the root cause of the issue and provide an update. |
|
The failure may be resolved by #209 -- try merging with the latest |
amzn-mdamine
force-pushed
the
release/4.0.x
branch
from
53973c9
to
026968f
Compare
|
#210 should fix it. |
|
@amzn-mdamine could you please rebase or merge with |
Signed-off-by: Mohamed Amine Ouali <mdamine@amazon.com>
amzn-mdamine
force-pushed
the
release/4.0.x
branch
from
026968f
to
6f5991a
Compare
|
I did the rebase. |
khieta
approved these changes
Sep 17, 2024
shaobo-he-aws
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #202