Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract variables for common utia and TIA amounts #2083

Closed
rootulp opened this issue Jul 11, 2023 · 1 comment
Closed

Extract variables for common utia and TIA amounts #2083

rootulp opened this issue Jul 11, 2023 · 1 comment
Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 11, 2023

Context

celestia-app/app/test/std_sdk_test.go

Line 101 in 8b5db4b

sdk.NewCoins(sdk.NewCoin(app.BondDenom, sdk.NewInt(1000000000000))),

Problem

It's not immediately obvious how many coins this is

Proposal

  1. Extract variables for common amounts used in this test file
  2. Consider refactoring all tests that use arbitrary coin amounts to use the variables extracted in step one
var (
	oneUtia = sdk.NewCoins(sdk.NewCoin(app.BondDenom, sdk.NewInt(1)))
	// oneTia is 1e6 utia (a.k.a one million utia)
	oneTia = sdk.NewCoins(sdk.NewCoin(app.BondDenom, sdk.NewInt(1e6)))
)
@rootulp rootulp added good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage labels Jul 11, 2023
Chirag018 added a commit to Chirag018/celestia-app that referenced this issue Oct 3, 2023
@Chirag018
Refactor: Extract Common UTIA and TIA Amounts into Variables
66959cf 
Closes celestiaorg#2083
@Chirag018 Chirag018 mentioned this issue Oct 3, 2023
Closed
Chirag018 added a commit to Chirag018/celestia-app that referenced this issue Oct 16, 2023
@Chirag018
refactor: extract variables for common utia and tia amounts
20d2ff2 
Closes celestiaorg#2083
@Chirag018 Chirag018 mentioned this issue Oct 16, 2023
Closed
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 28, 2023

Sorry @Chirag018, it looks like this isn't a high priority issue so let's close this as won't do for now.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
1 participant
@rootulp