Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract variables for common utia and tia amounts #2610

Closed
wants to merge 0 commits into from
Closed

refactor: extract variables for common utia and tia amounts #2610

wants to merge 0 commits into from

Conversation

Chirag018
Copy link
Contributor

Closes #2083

@celestia-bot celestia-bot requested a review from a team October 3, 2023 15:39
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #2610 (0b1ed0b) into main (dea20c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   20.63%   20.63%           
=======================================
  Files         133      133           
  Lines       15346    15346           
=======================================
  Hits         3166     3166           
  Misses      11877    11877           
  Partials      303      303

@Chirag018
Copy link
Contributor Author

Hey, @rootulp @evan-forbes even had a doubt, can we name 1e9(and 1e12) as onePtia/oneNtia or something?


sdk.NewCoins(sdk.NewCoin(app.BondDenom, sdk.NewInt(1000000000)))

evan-forbes
evan-forbes previously approved these changes Oct 3, 2023
View reviewed changes
app/test/std_sdk_test.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes dismissed their stale review October 3, 2023 17:06

golangci is failing

evan-forbes
evan-forbes requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to get the ci passing via running gofmt -s -w .

@celestia-bot celestia-bot requested a review from a team October 3, 2023 19:39
rootulp
rootulp reviewed Oct 4, 2023
View reviewed changes
test/util/common.go Outdated Show resolved Hide resolved
app/test/std_sdk_test.go Outdated Show resolved Hide resolved
@rootulp rootulp changed the title Refactor: Extract Common UTIA and TIA Amounts into Variables refactor: extract variables for common utia and tia amounts Oct 4, 2023
@celestia-bot celestia-bot requested a review from a team October 4, 2023 18:41
rootulp
rootulp reviewed Oct 4, 2023
View reviewed changes
test/util/common.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team October 4, 2023 18:59
rootulp
rootulp requested changes Oct 4, 2023
View reviewed changes
test/util/testnode/node_init.go Outdated Show resolved Hide resolved
app/test/prepare_proposal_context_test.go Outdated Show resolved Hide resolved
app/test/prepare_proposal_context_test.go Outdated Show resolved Hide resolved
app/test/integration_test.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team October 4, 2023 19:11
@rootulp
Copy link
Collaborator

rootulp commented Oct 5, 2023

golangci-lint is failing: https://github.com/celestiaorg/celestia-app/actions/runs/6410438714/job/17403743307?pr=2610#step:5:37503

also test is failing. It looks like an import cycle: https://github.com/celestiaorg/celestia-app/actions/runs/6410438714/job/17403744403?pr=2610#step:4:10

@Chirag018 Chirag018 closed this Oct 16, 2023
@Chirag018 Chirag018 mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes requested changes

@rootulp rootulp rootulp requested changes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@Chirag018 Chirag018

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract variables for common utia and TIA amounts
4 participants
@Chirag018 @codecov-commenter @rootulp @evan-forbes