Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker/doc: Document Dockerfile and Dockerfile.ephemeral in the docker/README.md #2118

Closed
Bidon15 opened this issue Jul 18, 2023 · 4 comments · Fixed by #2196
Closed

docker/doc: Document Dockerfile and Dockerfile.ephemeral in the docker/README.md #2118

Bidon15 opened this issue Jul 18, 2023 · 4 comments · Fixed by #2196
Assignees
@rootulp
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Bidon15
Copy link
Member

Bidon15 commented Jul 18, 2023 

          Yes. Ideally, we need to make a dedicated issue to document other 2 DockerFiles we have in the repo.

I started this ReadMe, so we can spec out not only the protocol, but what options do we have to run the software apart from vanilla make install && celestia-appd xyz in the host machine

Originally posted by @Bidon15 in #2052 (comment)
@Bidon15 Bidon15 added good first issue Good for newcomers documentation Improvements or additions to documentation docker and removed needs:triage labels Jul 18, 2023
@Bidon15 Bidon15 mentioned this issue Jul 18, 2023
Merged
@evan-forbes
Copy link
Member

I think we can delete the docker.ephemeral, correct? that was just for the ephemeral cluster iirc

@rootulp
Copy link
Collaborator

rootulp commented Jul 24, 2023

I think we can delete the docker.ephemeral, correct? that was just for the ephemeral cluster iirc

Context in #415 . Since https://github.com/celestiaorg/ephemeral-cluster is in archive mode, it may no longer be used in which case I agree we should remove Dockerfile_ephemeral

rootulp added a commit that referenced this issue Jul 24, 2023
@rootulp
chore: delete Dockerfile_ephemeral
426843a 
Motivation in #2118 (comment)
@rootulp rootulp mentioned this issue Jul 24, 2023
Merged
@evan-forbes
Copy link
Member

can we close this issue?

@rootulp rootulp self-assigned this Jul 31, 2023
@rootulp
Copy link
Collaborator

rootulp commented Jul 31, 2023

Looks like there's another Dockerfile (Dockerfile.test) that we should document or remove. I plan on removing.

@rootulp rootulp mentioned this issue Jul 31, 2023
Merged
@rootulp rootulp added this to the Post-mainnet milestone Jul 31, 2023
rootulp added a commit that referenced this issue Aug 1, 2023
@rootulp
chore: remove Dockerfile.test (#2196)
3212cc9 
Closes #2118

Dockerfile.test was moved from `contrib/` to `docker` in
#625 but it doesn't
appear used.
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
chore: remove Dockerfile.test (#2196)
47eb687 
Closes celestiaorg/celestia-app#2118

Dockerfile.test was moved from `contrib/` to `docker` in
celestiaorg/celestia-app#625 but it doesn't
appear used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove Dockerfile.test rootulp/celestia-app
3 participants
@Bidon15 @rootulp @evan-forbes