-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create repository official Dockerfile #415
Conversation
5934bae
to
3780815
Compare
The issue with this approach is
Even when mounted with the correct permissions, it still panics. Thus, forcing users to either:
Will keep on investigating this. |
The current way the above problem is solved is via adding a custom script that creates the |
Noice. I think creating an action for epheremal cluster makes sense and will be cool if this can be done within this PR Passing to @jbowen93 if he is ok with this approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final say to @jbowen93
@Bidon15 Awesome. Will add the GitHub action for ephemeral cluster if Josh agrees to these changes and think they make sense. |
Is this ready for review? |
@adlerjohn Waiting for Josh input to see whether to add a github action to this PR for the ephemeral cluster docker image or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay in review. Left some comments. I'm fine adding a gh action for ephemeral to a later PR.
Resolved comments and approved |
This PR simplifies the main Dockerfile for Celestia-app.
It creates an image containing the Celestia-app binary and doesn't take into account the other development related to it. For example, under
docker/
directory, we had aDockerfile
that was shaped to suite the ephemeral cluster needs. However, when tagged using GitHub actions, it was acting as the main Celestia-app docker image. Thus, if someone wants to use that image, they will have to follow a complex way of specifying the home directory and existing files. In the meanwhile, the official repository Dockerfile shouldn't be as opinionated as possible.Also, I renamed
docker/Dockerfile
todocker/Dockerfile_ephemeral
in case we need to keep that image for the ephemeral cluster. However, I suggest we add a new GitHub action that creates that image and tags it with a tag that reflect that it will be used for the ephemeral cluster, example :ghcr.io/celestiaorg/celestia-app-ephemeral:latest
(Let me know if we want to add that action so that I add it to this PR).This comes from the need of having a base Celestia-app docker image that will be built during integration tests.