Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addrbook fails when encountering a peer with errors #2784

Closed
rootulp opened this issue Oct 30, 2023 · 0 comments · Fixed by #2783
Closed

Addrbook fails when encountering a peer with errors #2784

rootulp opened this issue Oct 30, 2023 · 0 comments · Fixed by #2783
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 30, 2023

Context

celestia-app has a command to convert peers.txt into addrbook.json

Problem

If the command encounters an error, it stops immediately.

$ ./build/celestia-appd addrbook /Users/rootulp/git/rootulp/celestia/networks/celestia/peers.txt /Users/rootulp/git/rootulp/celestia/networks/celestia/addrbook.json
Error: Cannot add non-routable address b751ffe713e3e5d80e8f45c3bd5e640ee9a91cb9@10.129.127.95:26656

Proposal

Skip the problematic peer and continue making progress.
@rootulp rootulp self-assigned this Oct 30, 2023
@rootulp rootulp mentioned this issue Oct 30, 2023
Merged
rootulp added a commit that referenced this issue Oct 30, 2023
@rootulp
feat(addrbook): skip peers with errors (#2783)
c4c7e94 
Closes #2784
Part of celestiaorg/networks#513
rootulp added a commit to rootulp/celestia-app that referenced this issue Oct 31, 2023
@rootulp
feat(addrbook): skip peers with errors (celestiaorg#2783)
4c1776c 
Closes celestiaorg#2784
Part of celestiaorg/networks#513
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
feat(addrbook): skip peers with errors (#2783)
5fa570b 
Closes celestiaorg/celestia-app#2784
Part of celestiaorg/networks#513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(addrbook): skip peers with errors rootulp/celestia-app
1 participant
@rootulp