feat(addrbook): skip peers with errors #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
changed the title
cmwaters
approved these changes
Oct 30, 2023
rach-id
approved these changes
Oct 30, 2023
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Oct 31, 2023
rootulp
added a commit
that referenced
this pull request
Nov 1, 2023
Backports #2623 and #2783 ## Testing ``` $ ./build/celestia-appd addrbook ~/git/rootulp/celestia/networks/celestia/peers.txt ~/Downloads/addrbook.json Error adding b751ffe713e3e5d80e8f45c3bd5e640ee9a91cb9@10.129.127.95:26656: Cannot add non-routable address b751ffe713e3e5d80e8f45c3bd5e640ee9a91cb9@10.129.127.95:26656 Converted /Users/rootulp/git/rootulp/celestia/networks/celestia/peers.txt into /Users/rootulp/Downloads/addrbook.json $ head -n 10 /Users/rootulp/Downloads/addrbook.json { "key": "8957397890a66cd0f716cbc9", "addrs": [ { "addr": { "id": "a41b4bc451b1b71d537aa1018226e08d7fa7e44e", "ip": "5.255.77.44", "port": 26656 }, "src": { ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2784
Part of celestiaorg/networks#513