Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend consistent appHash test to include all state machine messages #3540

Closed
1 task
Tracked by #3475
ninabarbakadze opened this issue Jun 7, 2024 · 0 comments · Fixed by #3606
Closed
1 task
Tracked by #3475

Extend consistent appHash test to include all state machine messages #3540

ninabarbakadze opened this issue Jun 7, 2024 · 0 comments · Fixed by #3606
Assignees
@ninabarbakadze
Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@ninabarbakadze
Copy link
Member

Description

currently the consistent appHash test only covers 2 state machine messages, extend that test to include all existing state machine messages. Blocked by #3509

Acceptance Criteria

  • consistent_apphash_test.go executes all different msg types
@ninabarbakadze ninabarbakadze added needs:grooming items needs a status change, to be closed, or clearer AC. Item should be discussed next sync. WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc and removed needs:triage labels Jun 7, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Jun 7, 2024
Merged
ninabarbakadze added a commit that referenced this issue Jun 10, 2024
@ninabarbakadze @rootulp
test: consistent appHash between commits (#3513)
d851e3c 
## Overview

Fixes #2414 

### This test is split up in a few parts:

- Execute transactions deterministically on v1 and save the AppHash.
#3522 ([includes genesis
folder backport from
utils](#3520))
- Set up the same testApp environment on main, execute transactions and
assert that the AppHash matches the one from v1

### Verifying the AppHash: 

If you want to make sure that the expected AppHash is correct, you can
run the [non determinism test on
v1.x](#3522) that
generates it.

### Follow-ups:
#3509 
#3540

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
@evan-forbes evan-forbes removed the needs:grooming items needs a status change, to be closed, or clearer AC. Item should be discussed next sync. label Jun 17, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Jun 18, 2024
Closed
4 tasks
@evan-forbes evan-forbes mentioned this issue Jul 1, 2024
Closed
6 tasks
@ninabarbakadze ninabarbakadze mentioned this issue Jul 5, 2024
Merged
ninabarbakadze added a commit that referenced this issue Jul 23, 2024
@ninabarbakadze
test: expand apphash test with all state machine msgs (#3606)
891e0d3 
## Overview

Resolves #3540 & Resolves #3626

Expected AppHash generated from
#3665
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@ninabarbakadze @rootulp
test: consistent appHash between commits (#3513)
e69a3be 
## Overview

Fixes #2414 

### This test is split up in a few parts:

- Execute transactions deterministically on v1 and save the AppHash.
celestiaorg/celestia-app#3522 ([includes genesis
folder backport from
utils](celestiaorg/celestia-app#3520))
- Set up the same testApp environment on main, execute transactions and
assert that the AppHash matches the one from v1

### Verifying the AppHash: 

If you want to make sure that the expected AppHash is correct, you can
run the [non determinism test on
v1.x](celestiaorg/celestia-app#3522) that
generates it.

### Follow-ups:
#3509 
celestiaorg/celestia-app#3540

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
ninabarbakadze added a commit that referenced this issue Sep 17, 2024
@ninabarbakadze
test: expand apphash test with all state machine msgs (#3606)
d043fe5 
## Overview

Resolves #3540 & Resolves #3626

Expected AppHash generated from
#3665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: expand apphash test with all state machine msgs celestiaorg/celestia-app
3 participants
@cmwaters @evan-forbes @ninabarbakadze