Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve TODO for link in consistent apphash test #3626

Closed
rootulp opened this issue Jun 26, 2024 · 1 comment · Fixed by #3606
Closed

Resolve TODO for link in consistent apphash test #3626

rootulp opened this issue Jun 26, 2024 · 1 comment · Fixed by #3606
Assignees
@ninabarbakadze
Labels
needs:triage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 26, 2024

celestia-app/app/test/consistent_apphash_test.go

Line 42 in 9475c4b

// Expected app hash produced by v1.x - TODO: link to the test producing the hash

cc: @ninabarbakadze
@ninabarbakadze ninabarbakadze self-assigned this Jun 26, 2024
@ninabarbakadze
Copy link
Member

thanks @rootulp

@ninabarbakadze ninabarbakadze mentioned this issue Jul 5, 2024
Merged
ninabarbakadze added a commit that referenced this issue Sep 17, 2024
@ninabarbakadze
test: expand apphash test with all state machine msgs (#3606)
d043fe5 
## Overview

Resolves #3540 & Resolves #3626

Expected AppHash generated from
#3665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
needs:triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: expand apphash test with all state machine msgs celestiaorg/celestia-app
2 participants
@rootulp @ninabarbakadze