Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable IBC #412

Closed
Tracked by #514
, #1125
...
evan-forbes opened this issue May 16, 2022 · 2 comments · Fixed by #1215
Closed
Tracked by #514
, #1125
...

Re-enable IBC #412

evan-forbes opened this issue May 16, 2022 · 2 comments · Fixed by #1215
Assignees
@cmwaters
Labels
dependencies Pull requests that update a dependency file
Milestone
Incentivized Testnet

Comments

@evan-forbes
Copy link
Member

during the upgrade to v0.46.0 of the cosmos-sdk in #399, we commented out the ibc module installation into the app, as the ibc module did not have a release that was compatible with v0.46.0.

When there is a release ready, we should re-install the ibc module by un-commenting out the installation process.
@evan-forbes evan-forbes added dependencies Pull requests that update a dependency file C: Celestia app labels May 16, 2022
evan-forbes added a commit that referenced this issue May 16, 2022
@evan-forbes
add commets to ibc uninstall to point to issue #412
3a58c64
@evan-forbes evan-forbes mentioned this issue May 16, 2022
Merged
@adlerjohn adlerjohn moved this to TODO in Celestia Node May 16, 2022
evan-forbes added a commit that referenced this issue May 18, 2022
@evan-forbes
Upgrade to tendermint v0.35.4 and cosmos-sdk v0.46.0 (#399)
5e4a1dc 
* update app to be v0.46.0 compat

* remove store and mem keys as we shouldn't use these

* comment out the IBC modules for now as it is not ready

* use patch version of core and the sdk

* more small changes to get to compile

* replace cosmoscmd with local cmd infra

* add missing modules to set begin,init,end methods

* linter

* fix validate basic test

* comment out extra test case for now

* add a validator set to the genesis state of the testapp

* use default tx handler for middleware

* uncomment out test

* rename encoding config var to not overwrite encoding package

* use patched version of core that removes malleated txs from the v1 mempool

* linter

* docs

* remove commented code

* fix makefile

* add a command to change the mode to validator in script

* use a release instead of a commit

* add commets to ibc uninstall to point to issue #412

* get rid of all starport scaffolding comments

* add comment describing panic

* use a constant for env prefix

* include comment for picking default snapshot interval

* patch merge

* fix integration test

* remove print statement

* use release and not a specific commit
This was referenced Jul 1, 2022
Closed
Closed
@evan-forbes
Copy link
Member Author

we should upgrade to the latest stable version of IBC while we're at it

@evan-forbes evan-forbes added this to the Q4 2022 milestone Nov 15, 2022
@liamsi
Copy link
Member

liamsi commented Dec 4, 2022

Looks like ibc-go is getting close to be released (with a 0.46 compatible version): https://github.com/cosmos/ibc-go/releases/tag/v6.0.0-rc1

We should sync with the IBC team before using that during the incentivized testnet though.

@evan-forbes evan-forbes removed this from the Q4 2022 milestone Dec 8, 2022
@evan-forbes evan-forbes mentioned this issue Dec 14, 2022
Closed
5 tasks
@cmwaters cmwaters self-assigned this Dec 15, 2022
@evan-forbes evan-forbes added this to the Incentivized Testnet milestone Jan 2, 2023
@cmwaters cmwaters mentioned this issue Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Incentivized Testnet
Development

Successfully merging a pull request may close this issue.

Re-enable IBC celestiaorg/celestia-app
3 participants
@liamsi @cmwaters @evan-forbes