Upgrade to tendermint v0.35.4 and cosmos-sdk v0.46.0 #399
Conversation
evan-forbes
added
dependencies
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
- Coverage 26.12% 25.13% -1.00%
==========================================
Files 14 14
Lines 1860 1858 -2
==========================================
- Hits 486 467 -19
- Misses 1336 1353 +17
Partials 38 38
Continue to review full report at Codecov.
|
cmd/celestia-appd/main.go
Outdated
| func main() { | ||
| rootCmd, _ := cosmoscmd.NewRootCmd( | ||
| app.Name, | ||
| app.AccountAddressPrefix, | ||
| app.DefaultNodeHome, | ||
| app.Name, | ||
| app.ModuleBasics, | ||
| appBuilder, | ||
| // this line is used by starport scaffolding # root/arguments | ||
| ) | ||
| if err := svrcmd.Execute(rootCmd, app.DefaultNodeHome); err != nil { | ||
| rootCmd := NewRootCmd() | ||
| if err := svrcmd.Execute(rootCmd, "CELESTIA", app.DefaultNodeHome); err != nil { |
There was a problem hiding this comment.
We replace more starport code with our own infrastructure.
| // NewRootCmd creates a new root command for celestia-appd. It is called once in the | ||
| // main function. | ||
| func NewRootCmd() *cobra.Command { |
There was a problem hiding this comment.
This command can probably be cleaned up and more organized. I elected to do this in a different PR for time purposes, but if we want I'm happy to refactor to something cleaner and more organized
| // SetupWithGenesisValSet initializes GenesisState with a single validator and genesis accounts | ||
| // that also act as delegators. | ||
| func GenesisStateWithSingleValidator(t *testing.T, testApp *app.App) (app.GenesisState, *tmtypes.ValidatorSet) { |
There was a problem hiding this comment.
This might fix the issue @renaynay was running into with using a test application in celestia-node, as the network could not be setup due to improper initialization of the staking state/validator set
| sed -i 's/timeout_commit = "5s"/timeout_commit = "1s"/g' ~/.celestia-app/config/config.toml | ||
| sed -i 's/timeout_propose = "3s"/timeout_propose = "1s"/g' ~/.celestia-app/config/config.toml |
There was a problem hiding this comment.
Are we intentionally overwriting this for single node networks?
There was a problem hiding this comment.
yeah, tbh, I don't remember why or when we added this
| Block: &tmproto.BlockParams{ | ||
| MaxBytes: 200000, | ||
| MaxGas: 2000000, |
There was a problem hiding this comment.
Not sure why we would keep the blocks so small in tests 🤔
There was a problem hiding this comment.
so far, this test is only used for a few txs, as its only for unit tests. We might need to change this in the near future, depending on when and how we add more tests with large messages and full mempools
|
Surprised to see merge conflicts now. I think we did not change anything on main? |
we merged #224, so this makes sense. I tried to quickly merge last night, but ran into an issue and haven't time to finish debugging. |
Description
This PR updates the application to tendermint v0.35.4 and the cosmos-sdk to v0.46.0. While there are a wide variety of changes that included in this PR, each is needed to accommodate the latest version of the cosmos-sdk
blocked by celestiaorg/celestia-core#747
closes #376
related to #291