refactor prepare proposal to efficiently fill the square #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 26.12% 26.12%
=======================================
Files 14 14
Lines 1860 1860
=======================================
Hits 486 486
Misses 1336 1336
Partials 38 38
Continue to review full report at Codecov.
|
evan-forbes
force-pushed
the
evan/prepare-prop-refactor
branch
from
e0978fa
to
35fcff5
Compare
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
liamsi
reviewed
May 10, 2022
| } | ||
|
|
||
| dah := da.NewDataAvailabilityHeader(eds) | ||
| data.Hash = dah.Hash() |
There was a problem hiding this comment.
Nice. So this is not done in core at all anymore, right? I'm wondering if we should move some of the code that is currently in core to this repo actually 🤔
There was a problem hiding this comment.
I looked into this, but atm I think its best to keep it there. This is mainly because it makes it easier to test things. This could be a good goal for our next upgrade tho.
adlerjohn
reviewed
May 12, 2022
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
…tiaorg/celestia-app into evan/prepare-prop-refactor
adlerjohn
previously approved these changes
May 12, 2022
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
liamsi
approved these changes
May 13, 2022
adlerjohn
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
PrepareProposalPrepareProposalbased on the block data (errors on the side of over estimating)