Patch missing functionality needed for app in tendermint v0.35 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
T:Bug
evan-forbes
force-pushed
the
evan/fix-upgrade-to-35
branch
from
7760c10
to
96e4ca1
Compare
evan-forbes
changed the base branch from
release/v0.35.x-celestia
to
v0.35.x-celestia
liamsi
reviewed
May 12, 2022
liamsi
reviewed
May 12, 2022
adlerjohn
reviewed
May 12, 2022
adlerjohn
approved these changes
May 13, 2022
liamsi
approved these changes
May 13, 2022
unfortunately, there are quite a few tests in v0.35 that are flaky atm. I'm also still unsure why the proto is still breaking. We did the same changes as #716, but its still breaking. I'll merge for now, as this is blocking, but we should still investigate further. Worst case scenario we can remove the proto breakage test, but I would prefer to find out why obvi |
williambanfield
pushed a commit
to interchainio/celestia-core
that referenced
this pull request
Jul 14, 2022
…tiaorg#747) * pass the entire block data while processing proposal * remove malleated txs from the prioritized v1 mempool * patch flaky test * spelling Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * spel Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * fix old spelling error * use correct repo when comparing proto files Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrading celestia-core, I missed some basic functionality that is needed to update the app.
This PR:
ProcessProposal