Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and finalize resource pricing #658

Closed
Tracked by #669
evan-forbes opened this issue Aug 24, 2022 · 6 comments
Closed
Tracked by #669

Investigate and finalize resource pricing #658

evan-forbes opened this issue Aug 24, 2022 · 6 comments
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Aug 24, 2022

We need to investigate and decide on resource pricing. While we should easily be able to change the default gas configs found in tendermint and the sdk, its unclear how specific we can get as to adding multipliers to specific types of sdk txs.

@liamsi
Copy link
Member

liamsi commented Sep 5, 2022

My understanding is that for PayForData we want to measure account for the bytes but ideally we also want to add a constant cost per PfD s.t. batching is encouraged in the future. I do think this is possible and not difficult in the SDK.

For the other Txs types (sdk messages) I guess we rather want clarity on how exactly they are priced and if we want to change any of that default behaviour? One message type that comes to mind are the IBC related txs (so this issue/comment is kinda related here: #235 (comment)).

@adlerjohn adlerjohn self-assigned this Sep 5, 2022
@evan-forbes evan-forbes changed the title Finalize resource pricing Investigate and Finalize resource pricing Sep 26, 2022
@evan-forbes evan-forbes moved this to In Progress in Celestia Node Sep 26, 2022
@evan-forbes
Copy link
Member Author

The goal of this issue to is to document the formula used for each transaction type, so that we have a concrete understanding of how gas is deducted.

@evan-forbes evan-forbes added this to the Q4 2022 milestone Nov 15, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Nov 17, 2022

in #1029 , we're creating a script to run standard cosmos-sdk transactions on an inprocess network that has the ability to change genesis params and monitor gas. This should help us investigate gas params.
gas_consumption

@rootulp rootulp changed the title Investigate and Finalize resource pricing Investigate and finalize resource pricing Nov 17, 2022
evan-forbes added a commit that referenced this issue Nov 18, 2022
## Overview

We need to be able to modify the genesis state when using the testnode.
This PR refactors the testnode to allow for that. It also includes a
helper function that handles creation of this genesis state and simplify
the process of starting an in process node.

closes #1037 
part of/blocking #658 
spun out of and blocking #1029 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Co-authored-by: Rootul P <rootulp@gmail.com>
@evan-forbes evan-forbes modified the milestones: Q4 2022, Q1 2023 Dec 8, 2022
@evan-forbes
Copy link
Member Author

listing this as incentivized testnet stretch milestone, as we can change parameters and add docs at any time after the feature freeze without breaking anything. We also have a good idea of how much gas roughly a PFB takes up relative to other tx types, and we have code to trace the gas consumption of any transaction in any scenario should we need more precise data for a given situation.

@evan-forbes
Copy link
Member Author

evan-forbes commented Jan 18, 2023

referencing a comment where we discuss the gas costs of IBC. Notably, following the defaults of IBC, we are not charging gas per signature verified when updating the client.

#1125 (comment)

We would also like to investigate the reasoning behind the decision not to count gas for signature verification in IBC.

@evan-forbes
Copy link
Member Author

can close imo since we have the above analysis and have set the default min gas price to .1utia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants