Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: refactor the testnode to expose the genesis state #1038

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Nov 18, 2022

Overview

We need to be able to modify the genesis state when using the testnode. This PR refactors the testnode to allow for that. It also includes a helper function that handles creation of this genesis state and simplify the process of starting an in process node.

closes #1037
part of/blocking #658
spun out of and blocking #1029

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added this to the Q4 2022 milestone Nov 18, 2022
@evan-forbes evan-forbes self-assigned this Nov 18, 2022
rach-id
rach-id previously approved these changes Nov 18, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

testutil/testnode/full_node.go Outdated Show resolved Hide resolved
rootulp
rootulp previously approved these changes Nov 18, 2022
testutil/testnode/full_node.go Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@evan-forbes evan-forbes dismissed stale reviews from rootulp and rach-id via 2738659 November 18, 2022 14:18
@evan-forbes
Copy link
Member Author

for posterity, the testnode code could still use some serious refactors to make it easier to understand and more useful. There's only so much we can do to make the process of starting an in process node simpler, but yeah, this is only a step in the right direction instead of a final solution.

@codecov-commenter
Copy link

Codecov Report

Merging #1038 (2738659) into main (93f2c71) will decrease coverage by 0.27%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   51.16%   50.88%   -0.28%     
==========================================
  Files          71       71              
  Lines        4372     4398      +26     
==========================================
+ Hits         2237     2238       +1     
- Misses       1911     1936      +25     
  Partials      224      224              
Impacted Files Coverage Δ
testutil/testnode/node_init.go 63.97% <ø> (-1.95%) ⬇️
testutil/testnode/full_node.go 62.01% <46.15%> (-13.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes evan-forbes merged commit 8604be9 into main Nov 18, 2022
@evan-forbes evan-forbes deleted the evan/refactor-testnode-expose-genesis-state branch November 18, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose genesis state for the testnode
5 participants