-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: refactor the testnode to expose the genesis state #1038
chore!: refactor the testnode to expose the genesis state #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Rootul P <rootulp@gmail.com>
for posterity, the testnode code could still use some serious refactors to make it easier to understand and more useful. There's only so much we can do to make the process of starting an in process node simpler, but yeah, this is only a step in the right direction instead of a final solution. |
Codecov Report
@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 51.16% 50.88% -0.28%
==========================================
Files 71 71
Lines 4372 4398 +26
==========================================
+ Hits 2237 2238 +1
- Misses 1911 1936 +25
Partials 224 224
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Overview
We need to be able to modify the genesis state when using the testnode. This PR refactors the testnode to allow for that. It also includes a helper function that handles creation of this genesis state and simplify the process of starting an in process node.
closes #1037
part of/blocking #658
spun out of and blocking #1029
Checklist