-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add release_branches to version_bump to fix tag names #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
October 26, 2023 14:53
rootulp
previously approved these changes
Oct 26, 2023
MSevey
changed the title
bug: add release_branches to version_bump to fix tag names
ci: add release_branches to version_bump to fix tag names
Oct 26, 2023
evan-forbes
previously approved these changes
Oct 26, 2023
rootulp
previously approved these changes
Oct 26, 2023
rach-id
previously approved these changes
Oct 26, 2023
Last merge conflict 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #2773 +/- ##
=======================================
Coverage 19.70% 19.70%
=======================================
Files 139 139
Lines 17005 17005
=======================================
Hits 3350 3350
Misses 13333 13333
Partials 322 322 |
rootulp
approved these changes
Oct 27, 2023
rach-id
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The weird tag names was due to not providing the
release_branches
param.Proof: https://github.com/MSevey/celestia-app/tags
Closes #2688
Checklist