Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add release_branches to version_bump to fix tag names #2773

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 26, 2023

Overview

The weird tag names was due to not providing the release_branches param.

Proof: https://github.com/MSevey/celestia-app/tags

Closes #2688

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey self-assigned this Oct 26, 2023
@celestia-bot celestia-bot requested a review from a team October 26, 2023 14:53
rootulp
rootulp previously approved these changes Oct 26, 2023
@MSevey MSevey changed the title bug: add release_branches to version_bump to fix tag names ci: add release_branches to version_bump to fix tag names Oct 26, 2023
evan-forbes
evan-forbes previously approved these changes Oct 26, 2023
.github/workflows/ci-release.yml Show resolved Hide resolved
@MSevey MSevey dismissed stale reviews from evan-forbes and rootulp via 863db48 October 26, 2023 18:28
@celestia-bot celestia-bot requested a review from a team October 26, 2023 18:28
rootulp
rootulp previously approved these changes Oct 26, 2023
rach-id
rach-id previously approved these changes Oct 26, 2023
@MSevey MSevey dismissed stale reviews from rach-id and rootulp via 2f1d3d9 October 27, 2023 13:03
@celestia-bot celestia-bot requested a review from a team October 27, 2023 13:03
@MSevey MSevey enabled auto-merge (squash) October 27, 2023 13:03
@MSevey
Copy link
Member Author

MSevey commented Oct 27, 2023

Last merge conflict 🙏

@codecov-commenter
Copy link

Codecov Report

Merging #2773 (2f1d3d9) into main (36ecb01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2773   +/-   ##
=======================================
  Coverage   19.70%   19.70%           
=======================================
  Files         139      139           
  Lines       17005    17005           
=======================================
  Hits         3350     3350           
  Misses      13333    13333           
  Partials      322      322           

@MSevey MSevey merged commit 58b28cf into celestiaorg:main Oct 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release CI failed for v1
5 participants