Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release CI failed for v1 #2688

Closed
6 tasks
MSevey opened this issue Oct 17, 2023 · 0 comments · Fixed by #2773
Closed
6 tasks

Release CI failed for v1 #2688

MSevey opened this issue Oct 17, 2023 · 0 comments · Fixed by #2773
Assignees
@MSevey
Labels
bug Something isn't working

Comments

@MSevey
Copy link
Member

MSevey commented Oct 17, 2023

Summary of Bug

The release CI did not generate the right release when triggered for v1.

https://github.com/celestiaorg/celestia-app/actions/runs/6461462848/job/17541766728

Version

n/a

Steps to Reproduce

Some things to look into for reproducing

  • pre-release
  • rcs

The team had been generating rc releases as pre-releases and it appears that the ci pulled then older release, so it didn't capture any of the rc releases.

Things to resolve

  • Best practices for rcs and pre-releases, especially the combination of them.
  • test the version bump action for handling of rcs, pre-releases, and rc pre-releases

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@MSevey MSevey added the bug Something isn't working label Oct 17, 2023
@MSevey MSevey self-assigned this Oct 17, 2023
This was referenced Oct 26, 2023
Merged
Merged
MSevey added a commit that referenced this issue Oct 27, 2023
@MSevey
ci: add release_branches to version_bump to fix tag names (#2773)
58b28cf 
The weird tag names was due to not providing the `release_branches` param.

Proof: https://github.com/MSevey/celestia-app/tags

Closes #2688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSevey MSevey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add release_branches to version_bump to fix tag names MSevey/celestia-app
1 participant
@MSevey